You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/10/20 22:22:21 UTC

[GitHub] [beam] TheNeuralBit commented on a change in pull request #15757: [BEAM-13066, BEAM-13087] Workaround for coder type combiner packing iterable issue on legacy dataflow runner

TheNeuralBit commented on a change in pull request #15757:
URL: https://github.com/apache/beam/pull/15757#discussion_r733188453



##########
File path: sdks/python/apache_beam/transforms/combiners.py
##########
@@ -365,6 +365,10 @@ def push(hp, e):
               for element in bundle
           ]
           continue
+        # TODO(robertwb): Remove once legacy dataflow correctly handles

Review comment:
       Yeah I'm also unclear on this. Could you clarify @robertwb?
   
   The test does seem to [pass](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/2620/testReport/apache_beam.runners.portability.fn_api_runner.translations_test/TranslationsTest/test_run_packable_combine_globally/) on Dataflow V2, but I'm not really clear why.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org