You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@trafficserver.apache.org by "JosiahWI (via GitHub)" <gi...@apache.org> on 2023/06/13 16:26:47 UTC
[GitHub] [trafficserver] JosiahWI opened a new pull request, #9835: Fix error due to bad generator expression
JosiahWI opened a new pull request, #9835:
URL: https://github.com/apache/trafficserver/pull/9835
The build was broken due to CMake erroring on the generator expressions when jemalloc or hwloc were not present. This should fix it and make the logic more explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen merged pull request #9835: Fix error due to bad generator expression
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen merged PR #9835:
URL: https://github.com/apache/trafficserver/pull/9835
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficserver] cmcfarlen commented on a diff in pull request #9835: Fix error due to bad generator expression
Posted by "cmcfarlen (via GitHub)" <gi...@apache.org>.
cmcfarlen commented on code in PR #9835:
URL: https://github.com/apache/trafficserver/pull/9835#discussion_r1228426324
##########
src/tscore/CMakeLists.txt:
##########
@@ -118,6 +116,12 @@ target_link_libraries(tscore
PRIVATE
yaml-cpp::yaml-cpp
)
+if(TS_HAS_JEMALLOC)
+ target_link_libraries(tscore PUBLIC jemalloc:jemalloc)
Review Comment:
dropped a colon here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org