You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/09 10:58:19 UTC

[GitHub] [incubator-shardingsphere] jingshanglu commented on a change in pull request #5110: add support for test of JoinSpecfication

jingshanglu commented on a change in pull request #5110: add support for test of JoinSpecfication
URL: https://github.com/apache/incubator-shardingsphere/pull/5110#discussion_r406124415
 
 

 ##########
 File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/test/resources/sql/dml/select-or.xml
 ##########
 @@ -291,6 +291,26 @@
                 <table-factor>
                     <table name="t_order_item" alias="i" start-index="31" stop-index="42" />
                 </table-factor>
+                <joinSpecification>
 
 Review comment:
   In sharding-sql-test/src/main/resources/sql/supported/dml/select-or.xml

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services