You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Mike Quilleash (JIRA)" <ji...@apache.org> on 2008/09/24 10:43:44 UTC

[jira] Created: (CXF-1819) Make PhaseInterceptorChain.unwind() more defensive wrt handleFault() exceptions

Make PhaseInterceptorChain.unwind() more defensive wrt handleFault() exceptions
-------------------------------------------------------------------------------

                 Key: CXF-1819
                 URL: https://issues.apache.org/jira/browse/CXF-1819
             Project: CXF
          Issue Type: Improvement
          Components: Core
    Affects Versions: 2.1.1
            Reporter: Mike Quilleash


Currently the PhaseInterceptorChain.unwind() method looks like this (logging omitted)

        while (iterator.hasPrevious()) {
            Interceptor currentInterceptor = iterator.previous();
            currentInterceptor.handleFault(message);
        }

It would be better to defend against an exception in handleFault() as currently an exception thrown from a handleFault() stops the unwind.

New proposed code...

        while (iterator.hasPrevious()) {
            Interceptor currentInterceptor = iterator.previous();
            try {
                currentInterceptor.handleFault(message);
            catch (Exception e) {
                LOG.log( Level.ERROR, "Exception in handleFault on interceptor " + currentInterceptor, e);
             }
        }


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CXF-1819) Make PhaseInterceptorChain.unwind() more defensive wrt handleFault() exceptions

Posted by "Daniel Kulp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CXF-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-1819.
------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.4
                   2.0.10
         Assignee: Daniel Kulp

> Make PhaseInterceptorChain.unwind() more defensive wrt handleFault() exceptions
> -------------------------------------------------------------------------------
>
>                 Key: CXF-1819
>                 URL: https://issues.apache.org/jira/browse/CXF-1819
>             Project: CXF
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 2.1.1
>            Reporter: Mike Quilleash
>            Assignee: Daniel Kulp
>             Fix For: 2.0.10, 2.1.4
>
>
> Currently the PhaseInterceptorChain.unwind() method looks like this (logging omitted)
>         while (iterator.hasPrevious()) {
>             Interceptor currentInterceptor = iterator.previous();
>             currentInterceptor.handleFault(message);
>         }
> It would be better to defend against an exception in handleFault() as currently an exception thrown from a handleFault() stops the unwind.
> New proposed code...
>         while (iterator.hasPrevious()) {
>             Interceptor currentInterceptor = iterator.previous();
>             try {
>                 currentInterceptor.handleFault(message);
>             catch (Exception e) {
>                 LOG.log( Level.ERROR, "Exception in handleFault on interceptor " + currentInterceptor, e);
>              }
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.