You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@continuum.apache.org by ev...@apache.org on 2005/12/05 21:31:04 UTC

svn commit: r354160 - in /maven/continuum/trunk/continuum-notifiers: continuum-notifier-irc/src/main/java/org/apache/maven/continuum/notification/irc/ continuum-notifier-msn/src/main/java/org/apache/maven/continuum/notification/msn/

Author: evenisse
Date: Mon Dec  5 12:30:56 2005
New Revision: 354160

URL: http://svn.apache.org/viewcvs?rev=354160&view=rev
Log: (empty)

Modified:
    maven/continuum/trunk/continuum-notifiers/continuum-notifier-irc/src/main/java/org/apache/maven/continuum/notification/irc/IrcContinuumNotifier.java
    maven/continuum/trunk/continuum-notifiers/continuum-notifier-msn/src/main/java/org/apache/maven/continuum/notification/msn/MsnContinuumNotifier.java

Modified: maven/continuum/trunk/continuum-notifiers/continuum-notifier-irc/src/main/java/org/apache/maven/continuum/notification/irc/IrcContinuumNotifier.java
URL: http://svn.apache.org/viewcvs/maven/continuum/trunk/continuum-notifiers/continuum-notifier-irc/src/main/java/org/apache/maven/continuum/notification/irc/IrcContinuumNotifier.java?rev=354160&r1=354159&r2=354160&view=diff
==============================================================================
--- maven/continuum/trunk/continuum-notifiers/continuum-notifier-irc/src/main/java/org/apache/maven/continuum/notification/irc/IrcContinuumNotifier.java (original)
+++ maven/continuum/trunk/continuum-notifiers/continuum-notifier-irc/src/main/java/org/apache/maven/continuum/notification/irc/IrcContinuumNotifier.java Mon Dec  5 12:30:56 2005
@@ -221,13 +221,16 @@
     {
         try
         {
-            project = store.getProjectWithBuilds( project.getId() );
+            // TODO: prefer to remove this and get them up front
+            if ( project.getId() > 0 )
+            {
+                project = store.getProjectWithBuilds( project.getId() );
+            }
         }
         catch ( ContinuumStoreException e )
         {
             throw new ContinuumException( "Unable to obtain project builds", e );
         }
-
         List builds = project.getBuildResults();
 
         if ( builds.size() < 2 )

Modified: maven/continuum/trunk/continuum-notifiers/continuum-notifier-msn/src/main/java/org/apache/maven/continuum/notification/msn/MsnContinuumNotifier.java
URL: http://svn.apache.org/viewcvs/maven/continuum/trunk/continuum-notifiers/continuum-notifier-msn/src/main/java/org/apache/maven/continuum/notification/msn/MsnContinuumNotifier.java?rev=354160&r1=354159&r2=354160&view=diff
==============================================================================
--- maven/continuum/trunk/continuum-notifiers/continuum-notifier-msn/src/main/java/org/apache/maven/continuum/notification/msn/MsnContinuumNotifier.java (original)
+++ maven/continuum/trunk/continuum-notifiers/continuum-notifier-msn/src/main/java/org/apache/maven/continuum/notification/msn/MsnContinuumNotifier.java Mon Dec  5 12:30:56 2005
@@ -107,7 +107,7 @@
 
         if ( source.equals( ContinuumNotificationDispatcher.MESSAGE_ID_BUILD_COMPLETE ) )
         {
-            sendMessage( project, build, recipients, configuration );
+            buildComplete( project, build, recipients, configuration );
         }
     }
 
@@ -149,7 +149,7 @@
         return message + " " + getReportUrl( project, build, configurationService );
     }
 
-    private void sendMessage( Project project, BuildResult build, Set recipients, Map configuration )
+    private void buildComplete( Project project, BuildResult build, Set recipients, Map configuration )
         throws NotificationException
     {
         String message;