You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Valentyn Tymofieiev (JIRA)" <ji...@apache.org> on 2019/05/16 18:07:00 UTC
[jira] [Commented] (BEAM-6623) Dataflow ValidatesRunner test suite
should also exercise ValidatesRunner tests under Python 3.
[ https://issues.apache.org/jira/browse/BEAM-6623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16841594#comment-16841594 ]
Valentyn Tymofieiev commented on BEAM-6623:
-------------------------------------------
I think there are a few remaining steps here:
1. "Run Python DataflowValidatesRunner" command in Jenkins should trigger Py3.5 - 3.7 ValidatesRunner suites. Currently it only triggers Py2 suites: https://github.com/apache/beam/blob/3806d5222600503b622e371631e04dd699095b9b/.test-infra/jenkins/job_PostCommit_Python_ValidatesRunner_Dataflow.groovy#L35.
2. Once #1 is done, we can remove ValidatesRunner Py35 suite from postcommit runs: https://github.com/apache/beam/blob/adb6d0c9f790c9cda363dd5d14f03fb11362f4d1/build.gradle#L207.
3. ValidatesRunner Py3 tests should include streaming tests. Currently we only have ValidatesRunner batch tests (only for py35): see https://github.com/apache/beam/blob/abece47cc1c1c88a519e54e67a2d358b439cf69c/sdks/python/test-suites/dataflow/py35/build.gradle#L55. We need to add streaming validatesrunner tests for py35, 36, 37. See an example for ValidatesRunner streaming tests on Py2: https://github.com/apache/beam/blob/abece47cc1c1c88a519e54e67a2d358b439cf69c/sdks/python/build.gradle#L235.
> Dataflow ValidatesRunner test suite should also exercise ValidatesRunner tests under Python 3.
> ----------------------------------------------------------------------------------------------
>
> Key: BEAM-6623
> URL: https://issues.apache.org/jira/browse/BEAM-6623
> Project: Beam
> Issue Type: Sub-task
> Components: testing
> Reporter: Valentyn Tymofieiev
> Assignee: Mark Liu
> Priority: Critical
> Fix For: Not applicable
>
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)