You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by jpeach <gi...@git.apache.org> on 2016/07/14 07:58:23 UTC
[GitHub] trafficserver pull request #797: TS-4659: Log format errors on startup.
GitHub user jpeach opened a pull request:
https://github.com/apache/trafficserver/pull/797
TS-4659: Log format errors on startup.
Remove extraneous field name constants which accidentally match
with strstr().
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jpeach/trafficserver fix/4659
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/797.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #797
----
commit a941a647efd99e23cc9b74810128f991c4124d16
Author: James Peach <jp...@apache.org>
Date: 2016-07-14T07:49:15Z
TS-4659: Log format errors on startup.
Remove extraneous field name constants which accidentally match
with strstr().
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #797: TS-4659: Log format errors on startup.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/797
Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/321/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #797: TS-4659: Log format errors on startup.
Posted by zwoop <gi...@git.apache.org>.
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/797
The patch seems fine, but I'm a little concerned why those were put in there to begin with? Obviously some sort of sentinel at some point? As long as we don't need those, I'm +1 on this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #797: TS-4659: Log format errors on startup.
Posted by atsci <gi...@git.apache.org>.
Github user atsci commented on the issue:
https://github.com/apache/trafficserver/pull/797
FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/427/ for details.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver issue #797: TS-4659: Log format errors on startup.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach commented on the issue:
https://github.com/apache/trafficserver/pull/797
The original code used the enum value as a sentinel so it would never have hit the empty strings at the ends of the lists.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request #797: TS-4659: Log format errors on startup.
Posted by jpeach <gi...@git.apache.org>.
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/797
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---