You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Gregory Shimansky (JIRA)" <ji...@apache.org> on 2007/10/26 18:53:52 UTC
[jira] Created: (HARMONY-5033) [drlvm][jvmti][x86_64]
FieldModificationEvent should support compressed references on x86_64
[drlvm][jvmti][x86_64] FieldModificationEvent should support compressed references on x86_64
--------------------------------------------------------------------------------------------
Key: HARMONY-5033
URL: https://issues.apache.org/jira/browse/HARMONY-5033
Project: Harmony
Issue Type: Bug
Components: DRLVM
Environment: Linux/Windows x86_64
Reporter: Gregory Shimansky
In the jvmti_field_modification_callback argument p_new_value contains an uncompressed reference from JIT stack. It has to be compressed in compressed mode to create an argument for JVMTI callback. The following 2 tests crash currently:
org.apache.harmony.jpda.tests.jdwp.Events.FieldModification002Test
org.apache.harmony.jpda.tests.jdwp.Events.FieldModificationTest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5033) [drlvm][jvmti]
FieldModificationEvent should support compressed references on x86_64
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky updated HARMONY-5033:
---------------------------------------
Summary: [drlvm][jvmti] FieldModificationEvent should support compressed references on x86_64 (was: [drlvm][jvmti][x86_64] FieldModificationEvent should support compressed references on x86_64)
> [drlvm][jvmti] FieldModificationEvent should support compressed references on x86_64
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-5033
> URL: https://issues.apache.org/jira/browse/HARMONY-5033
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Linux/Windows x86_64
> Reporter: Gregory Shimansky
> Attachments: buildrun.bat, buildrun.sh, test.cpp, Test.java
>
>
> In the jvmti_field_modification_callback argument p_new_value contains an uncompressed reference from JIT stack. It has to be compressed in compressed mode to create an argument for JVMTI callback. The following 2 tests crash currently:
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModification002Test
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModificationTest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5033) [drlvm][jvmti][x86_64]
FieldModificationEvent should support compressed references on x86_64
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk updated HARMONY-5033:
-------------------------------------
Attachment: buildrun.sh
buildrun.bat
> [drlvm][jvmti][x86_64] FieldModificationEvent should support compressed references on x86_64
> --------------------------------------------------------------------------------------------
>
> Key: HARMONY-5033
> URL: https://issues.apache.org/jira/browse/HARMONY-5033
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Linux/Windows x86_64
> Reporter: Gregory Shimansky
> Attachments: buildrun.bat, buildrun.sh, test.cpp, Test.java
>
>
> In the jvmti_field_modification_callback argument p_new_value contains an uncompressed reference from JIT stack. It has to be compressed in compressed mode to create an argument for JVMTI callback. The following 2 tests crash currently:
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModification002Test
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModificationTest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5033) [drlvm][jvmti]
FieldModificationEvent should support compressed references on x86_64
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky reassigned HARMONY-5033:
------------------------------------------
Assignee: Gregory Shimansky
> [drlvm][jvmti] FieldModificationEvent should support compressed references on x86_64
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-5033
> URL: https://issues.apache.org/jira/browse/HARMONY-5033
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Linux/Windows x86_64
> Reporter: Gregory Shimansky
> Assignee: Gregory Shimansky
> Attachments: buildrun.bat, buildrun.sh, H-5033.patch, test.cpp, Test.java
>
>
> In the jvmti_field_modification_callback argument p_new_value contains an uncompressed reference from JIT stack. It has to be compressed in compressed mode to create an argument for JVMTI callback. The following 2 tests crash currently:
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModification002Test
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModificationTest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5033) [drlvm][jvmti] FieldModificationEvent
should support compressed references on x86_64
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky closed HARMONY-5033.
--------------------------------------
JDWP test on field watches works now.
> [drlvm][jvmti] FieldModificationEvent should support compressed references on x86_64
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-5033
> URL: https://issues.apache.org/jira/browse/HARMONY-5033
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Linux/Windows x86_64
> Reporter: Gregory Shimansky
> Assignee: Gregory Shimansky
> Attachments: buildrun.bat, buildrun.sh, H-5033.patch, test.cpp, Test.java
>
>
> In the jvmti_field_modification_callback argument p_new_value contains an uncompressed reference from JIT stack. It has to be compressed in compressed mode to create an argument for JVMTI callback. The following 2 tests crash currently:
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModification002Test
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModificationTest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5033) [drlvm][jvmti]
FieldModificationEvent should support compressed references on x86_64
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk updated HARMONY-5033:
-------------------------------------
Attachment: H-5033.patch
With HARMONY-5035 fixed, the simple test and JDWP tests do not crash.
I've tried simple test, and got the following result when Java code sets 'null' object value:
1) for uncompressed mode object pointer is NULL;
2) for compressed mode FieldModification callback reports non-null jobject pointing to managed_null (i.e. start address of Java heap). RE reports null jobject in this case.
Suggested patch fixes this problem.
> [drlvm][jvmti] FieldModificationEvent should support compressed references on x86_64
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-5033
> URL: https://issues.apache.org/jira/browse/HARMONY-5033
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Linux/Windows x86_64
> Reporter: Gregory Shimansky
> Attachments: buildrun.bat, buildrun.sh, H-5033.patch, test.cpp, Test.java
>
>
> In the jvmti_field_modification_callback argument p_new_value contains an uncompressed reference from JIT stack. It has to be compressed in compressed mode to create an argument for JVMTI callback. The following 2 tests crash currently:
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModification002Test
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModificationTest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5033) [drlvm][jvmti][x86_64]
FieldModificationEvent should support compressed references on x86_64
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk updated HARMONY-5033:
-------------------------------------
Attachment: Test.java
test.cpp
The test I used for investigation.
> [drlvm][jvmti][x86_64] FieldModificationEvent should support compressed references on x86_64
> --------------------------------------------------------------------------------------------
>
> Key: HARMONY-5033
> URL: https://issues.apache.org/jira/browse/HARMONY-5033
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Linux/Windows x86_64
> Reporter: Gregory Shimansky
> Attachments: buildrun.bat, buildrun.sh, test.cpp, Test.java
>
>
> In the jvmti_field_modification_callback argument p_new_value contains an uncompressed reference from JIT stack. It has to be compressed in compressed mode to create an argument for JVMTI callback. The following 2 tests crash currently:
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModification002Test
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModificationTest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5033) [drlvm][jvmti]
FieldModificationEvent should support compressed references on x86_64
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky resolved HARMONY-5033.
----------------------------------------
Resolution: Fixed
Patch is applied at 595048.
> [drlvm][jvmti] FieldModificationEvent should support compressed references on x86_64
> ------------------------------------------------------------------------------------
>
> Key: HARMONY-5033
> URL: https://issues.apache.org/jira/browse/HARMONY-5033
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Linux/Windows x86_64
> Reporter: Gregory Shimansky
> Assignee: Gregory Shimansky
> Attachments: buildrun.bat, buildrun.sh, H-5033.patch, test.cpp, Test.java
>
>
> In the jvmti_field_modification_callback argument p_new_value contains an uncompressed reference from JIT stack. It has to be compressed in compressed mode to create an argument for JVMTI callback. The following 2 tests crash currently:
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModification002Test
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModificationTest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-5033) [drlvm][jvmti][x86_64]
FieldModificationEvent should support compressed references on x86_64
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12538371 ]
Ilya Berezhniuk commented on HARMONY-5033:
------------------------------------------
Looks like the problem actually is not in compressed references.
When JET invokes rt_helper_ti_field_modification stub on x86_64, it passes 5th parameter (p_new_value in jvmti_field_modification_callback) incorrectly.
I've filed HARMONY-5035 for this issue.
> [drlvm][jvmti][x86_64] FieldModificationEvent should support compressed references on x86_64
> --------------------------------------------------------------------------------------------
>
> Key: HARMONY-5033
> URL: https://issues.apache.org/jira/browse/HARMONY-5033
> Project: Harmony
> Issue Type: Bug
> Components: DRLVM
> Environment: Linux/Windows x86_64
> Reporter: Gregory Shimansky
>
> In the jvmti_field_modification_callback argument p_new_value contains an uncompressed reference from JIT stack. It has to be compressed in compressed mode to create an argument for JVMTI callback. The following 2 tests crash currently:
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModification002Test
> org.apache.harmony.jpda.tests.jdwp.Events.FieldModificationTest
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.