[superset] branch master updated: fix(tags): convert postgres enum type to varchar (#23526)

[ta...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

tai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 068163e2a1 fix(tags): convert postgres enum type to varchar (#23526)
068163e2a1 is described below

commit 068163e2a1151d4ccd5d7c9a87cbadc9facda40d
Author: ʈᵃᵢ <td...@gmail.com>
AuthorDate: Thu Mar 30 17:21:18 2023 -0700

    fix(tags): convert postgres enum type to varchar (#23526)
---
 ...2af1b_drop_postgres_enum_constrains_for_tags.py | 47 ++++++++++++++++++++++
 1 file changed, 47 insertions(+)

diff --git a/superset/migrations/versions/2023-03-29_20-30_07f9a902af1b_drop_postgres_enum_constrains_for_tags.py b/superset/migrations/versions/2023-03-29_20-30_07f9a902af1b_drop_postgres_enum_constrains_for_tags.py
new file mode 100644
index 0000000000..442f2b3b86
--- /dev/null
+++ b/superset/migrations/versions/2023-03-29_20-30_07f9a902af1b_drop_postgres_enum_constrains_for_tags.py
@@ -0,0 +1,47 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+"""drop postgres enum constrains for tags
+
+Revision ID: 07f9a902af1b
+Revises: b5ea9d343307
+Create Date: 2023-03-29 20:30:10.214951
+
+"""
+
+# revision identifiers, used by Alembic.
+revision = "07f9a902af1b"
+down_revision = "b5ea9d343307"
+
+from alembic import op
+from sqlalchemy.dialects import postgresql
+
+
+def upgrade():
+    conn = op.get_bind()
+    if isinstance(conn.dialect, postgresql.dialect):
+        conn.execute(
+            'ALTER TABLE "tagged_object" ALTER COLUMN "object_type" TYPE VARCHAR'
+        )
+        conn.execute('ALTER TABLE "tag" ALTER COLUMN "type" TYPE VARCHAR')
+        conn.execute("DROP TYPE objecttypes")
+        conn.execute("DROP TYPE tagtypes")
+
+
+def downgrade():
+    # Leaving the column type as VARCHAR in case the column contains values that
+    # do not comply with the previous enum type
+    pass