You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Branko Čibej <br...@xbc.nu> on 2003/03/23 21:03:36 UTC
Re: svn commit: rev 5428 - trunk/build/generator
gstein@tigris.org wrote:
>+_filter_names = [
>+ 'svn_boolean_t', # svn_config_enumerator_t looks like (to our regex) a
>+ # function declaration for svn_boolean_t
>+ ]
>
Huh! Why don't you filter on the presence of "typedef" at the beginning
of the line instead?
And I think the regex could be simplified (and made safer) by making it
a multiline search that requires a leading type name or typedef,
balanced parens and stops at "\)\s*;".
--
Brane Čibej <br...@xbc.nu> http://www.xbc.nu/brane/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 5428 - trunk/build/generator
Posted by Greg Stein <gs...@lyra.org>.
On Sun, Mar 23, 2003 at 10:03:36PM +0100, Branko ??ibej wrote:
> gstein@tigris.org wrote:
>
> >+_filter_names = [
> >+ 'svn_boolean_t', # svn_config_enumerator_t looks like (to our regex) a
> >+ # function declaration for svn_boolean_t
> >+ ]
> >
>
> Huh! Why don't you filter on the presence of "typedef" at the beginning
> of the line instead?
Looking for typedef would work, sure. But...
> And I think the regex could be simplified (and made safer) by making it
> a multiline search that requires a leading type name or typedef,
> balanced parens and stops at "\)\s*;".
There is no need for this. The extractor works just fine right now. We have
*very* regular headers, so the svn_boolean_t was the only funky thing. I
decided to filter specific names in case other stuff comes up in the future.
Simply trimming out the crap is much easier than revamping the regex.
My next task is to associate each header file with a library so that we can
generate a .def file for a particular library, based on parsing a particular
set of headers for that library. My alternate approach would be to divvy it
based on the FOO from symbols named svn_FOO_* (i.e. know the various FOO
names that go into a given library).
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org