You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/08/16 15:26:47 UTC
[GitHub] [rocketmq-schema-registry] ferrirW opened a new pull request, #42: [ISSUE #39] Parse idl fields to return getSchemaResponse
ferrirW opened a new pull request, #42:
URL: https://github.com/apache/rocketmq-schema-registry/pull/42
return schema fields like this:
"fields": [
{
"pos": 0,
"name": "a",
"type": "string",
"comment": null,
"isNullable": false,
"defaultValue": "null",
"sortType": "ASCENDING",
"extra": ""
},
{
"pos": 1,
"name": "b",
"type": "double",
"comment": null,
"isNullable": true,
"defaultValue": 0.0,
"sortType": "ASCENDING",
"extra": ""
}
],
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-schema-registry] ShannonDing commented on a diff in pull request #42: [ISSUE #39] Parse idl fields to return getSchemaResponse
Posted by GitBox <gi...@apache.org>.
ShannonDing commented on code in PR #42:
URL: https://github.com/apache/rocketmq-schema-registry/pull/42#discussion_r949766181
##########
common/src/main/java/org/apache/rocketmq/schema/registry/common/dto/GetSchemaResponse.java:
##########
@@ -50,6 +53,9 @@ public class GetSchemaResponse extends BaseDto {
@ApiModelProperty(value = "Schema idl")
private String idl;
+ @ApiModelProperty(value = "Schema idl")
Review Comment:
value = "Schema idl fields"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-schema-registry] ni-ze merged pull request #42: [ISSUE #39] Parse idl fields to return getSchemaResponse
Posted by GitBox <gi...@apache.org>.
ni-ze merged PR #42:
URL: https://github.com/apache/rocketmq-schema-registry/pull/42
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-schema-registry] codecov-commenter commented on pull request #42: [ISSUE #39] Parse idl fields to return getSchemaResponse
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #42:
URL: https://github.com/apache/rocketmq-schema-registry/pull/42#issuecomment-1216984202
# [Codecov](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/42?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#42](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/42?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a6388bb) into [main](https://codecov.io/gh/apache/rocketmq-schema-registry/commit/b0888c3fd0b75d4cca49c30992be890dd436733c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b0888c3) will **increase** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #42 +/- ##
==========================================
+ Coverage 9.57% 9.58% +0.01%
Complexity 25 25
==========================================
Files 37 37
Lines 773 772 -1
Branches 40 40
==========================================
Hits 74 74
+ Misses 693 692 -1
Partials 6 6
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/42?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...tmq/schema/registry/core/api/RequestProcessor.java](https://codecov.io/gh/apache/rocketmq-schema-registry/pull/42/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvc2NoZW1hL3JlZ2lzdHJ5L2NvcmUvYXBpL1JlcXVlc3RQcm9jZXNzb3IuamF2YQ==) | `0.00% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org