[GitHub] [sling-org-apache-sling-i18n] kwin commented on a change in pull request #7: SLING-10884 add exclusion for the i18n ResourceBundleProvider

[GitBox <gi...@apache.org>]

kwin commented on a change in pull request #7:
URL: https://github.com/apache/sling-org-apache-sling-i18n/pull/7#discussion_r739527347



##########
File path: src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java
##########
@@ -167,6 +171,9 @@
 
     private BundleTracker<Set<LocatorPaths>> locatorPathsTracker;
     private List<LocatorPaths> locatorPaths = new CopyOnWriteArrayList<>();
+    
+    // Ignore events in these paths

Review comment:
       There is no need to copy the values around. Just access directly from the config object.

##########
File path: src/main/java/org/apache/sling/i18n/impl/JcrResourceBundleProvider.java
##########
@@ -111,6 +111,10 @@
                 description = "In case of dictionary change events the cached "+
                         "resource bundle becomes invalid after the given delay (in ms). ")
         long invalidation_delay() default 5000;
+        
+        @AttributeDefinition(name="Excluded paths",
+                description="Do not check these paths for new ResourceBundles")

Review comment:
       The startsWith semantics should be mentioned




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org