[iceberg] branch master updated: Arrow: Fix errorprone warnings (#7498)

[et...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

etudenhoefner pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/iceberg.git


The following commit(s) were added to refs/heads/master by this push:
     new 98f4bc427f Arrow: Fix errorprone warnings (#7498)
98f4bc427f is described below

commit 98f4bc427fae3f19689f3eea8d43a409c5724c4f
Author: Ajantha Bhat <aj...@gmail.com>
AuthorDate: Mon May 8 11:43:39 2023 +0530

    Arrow: Fix errorprone warnings (#7498)
---
 .../org/apache/iceberg/arrow/vectorized/ColumnVector.java    | 12 ++++++++++--
 baseline.gradle                                              |  1 +
 .../main/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java | 12 +++++++-----
 3 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/ColumnVector.java b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/ColumnVector.java
index e05bfc4b3a..b95b02f1ec 100644
--- a/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/ColumnVector.java
+++ b/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/ColumnVector.java
@@ -56,12 +56,20 @@ public class ColumnVector implements AutoCloseable {
     this.accessor = getVectorAccessor(vectorHolder);
   }
 
-  /** @return the potentially dict-encoded {@link FieldVector}. */
+  /**
+   * Returns the potentially dict-encoded {@link FieldVector}.
+   *
+   * @return instance of {@link FieldVector}
+   */
   public FieldVector getFieldVector() {
     return vectorHolder.vector();
   }
 
-  /** @return decodes a dict-encoded vector and returns the actual arrow vector. */
+  /**
+   * Decodes a dict-encoded vector and returns the actual arrow vector.
+   *
+   * @return instance of {@link FieldVector}
+   */
   public FieldVector getArrowVector() {
     return DictEncodedArrowConverter.toArrowVector(vectorHolder, accessor);
   }
diff --git a/baseline.gradle b/baseline.gradle
index 04fad576c1..770db50629 100644
--- a/baseline.gradle
+++ b/baseline.gradle
@@ -98,6 +98,7 @@ subprojects {
           // Enforce missing override
           '-Xep:MissingOverride:ERROR',
           '-Xep:IntLongMath:ERROR',
+          '-Xep:MissingSummary:ERROR',
       )
     }
   }
diff --git a/hive3/src/main/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java b/hive3/src/main/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java
index cfee55f354..2568fd4e98 100644
--- a/hive3/src/main/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java
+++ b/hive3/src/main/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java
@@ -203,11 +203,13 @@ public class OrcSplit extends FileSplit implements ColumnarSplit, LlapAwareSplit
   }
 
   /**
-   * @return {@code true} if file schema doesn't have Acid metadata columns Such file may be in a
-   *     delta_x_y/ or base_x due to being added via "load data" command. It could be at
-   *     partition|table root due to table having been converted from non-acid to acid table. It
-   *     could even be something like "warehouse/t/HIVE_UNION_SUBDIR_15/000000_0" if it was written
-   *     by an "insert into t select ... from A union all select ... from B"
+   * Returns {@code true} if file schema doesn't have Acid metadata columns Such file may be in a
+   * delta_x_y/ or base_x due to being added via "load data" command. It could be at partition|table
+   * root due to table having been converted from non-acid to acid table. It could even be something
+   * like "warehouse/t/HIVE_UNION_SUBDIR_15/000000_0" if it was written by an "insert into t select
+   * ... from A union all select ... from B"
+   *
+   * @return {@code true} if file schema doesn't have Acid metadata columns
    */
   public boolean isOriginal() {
     return isOriginal;