You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/03/16 18:48:38 UTC

[GitHub] [arrow] minyoung commented on a change in pull request #12641: ARROW-15946: [Go] Fix memory leak in pqarrow.NewColumnWriter when writing nested data

minyoung commented on a change in pull request #12641:
URL: https://github.com/apache/arrow/pull/12641#discussion_r828322776



##########
File path: go/parquet/pqarrow/path_builder.go
##########
@@ -555,7 +555,6 @@ type multipathLevelResult struct {
 }
 
 func (m *multipathLevelResult) Release() {
-	m.leafArr.Release()

Review comment:
       `pathBuilder.addTerminalInfo` itself does call `paths.primitiveArr.Retain` (and a corresponding `Release`), so I think this is safe to remove? This would also explain why the leak only happens with nested types (because they have an extra array not released by this `leafArr.Release`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org