You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by venkata swamy babu budumuru <ve...@citrix.com> on 2013/10/15 12:38:03 UTC
Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN
Ranges
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14319/#review27016
-----------------------------------------------------------
test/integration/component/test_non_contiguous_vlan.py
<https://reviews.apache.org/r/14319/#comment52585>
1. Have something like "self.phy_network" instead of slf.network. This is little confusing.
2. This script is fetch phy network info here as well as in setNonContiguousVlanIds. Can you remove the redundancy here?
test/integration/component/test_non_contiguous_vlan.py
<https://reviews.apache.org/r/14319/#comment52586>
I dont see this instructions and the steps mentioned in the doc string matches. Can you please double check this test?
- venkata swamy babu budumuru
On Sept. 30, 2013, 8:21 a.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14319/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2013, 8:21 a.m.)
>
>
> Review request for cloudstack, Harikrishna Patnala, venkata swamy babu budumuru, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation test cases for feature - Non Contiguous VLAN ranges
> CLOUDSTACk 2238.
>
>
> Diffs
> -----
>
> test/integration/component/test_non_contiguous_vlan.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14319/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN
Ranges
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On Oct. 15, 2013, 4:08 p.m., venkata swamy babu budumuru wrote:
> > test/integration/component/test_non_contiguous_vlan.py, line 117
> > <https://reviews.apache.org/r/14319/diff/3/?file=359634#file359634line117>
> >
> > 1. Have something like "self.phy_network" instead of slf.network. This is little confusing.
> >
> > 2. This script is fetch phy network info here as well as in setNonContiguousVlanIds. Can you remove the redundancy here?
>
> Gaurav Aradhye wrote:
> Sure, will do.
Removed the redundancy
> On Oct. 15, 2013, 4:08 p.m., venkata swamy babu budumuru wrote:
> > test/integration/component/test_non_contiguous_vlan.py, line 311
> > <https://reviews.apache.org/r/14319/diff/3/?file=359634#file359634line311>
> >
> > I dont see this instructions and the steps mentioned in the doc string matches. Can you please double check this test?
>
> Gaurav Aradhye wrote:
> The test verifies that if the vlan id in a range is in use, then that vlan range can't be removed.
> The test updates the vlan with a range, deploys an instance so that it automatically creates a network which uses a vlan id from the current range.
> Then it tries to update vlan with different range (This is same as removing the current range). It is checked that this operation should fail.
>
> Please let me know which step is unclear so that I can update it with appropriate comment.
>
Provided the comments so that the steps are clear.
Also, added one condition where the vlan id from the existing range is in use. In that case, removing this range should throw error and test case purpose succeeds at this step only, no need to go on adding new range and use vlan id from the new range.
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14319/#review27016
-----------------------------------------------------------
On Oct. 15, 2013, 7:23 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14319/
> -----------------------------------------------------------
>
> (Updated Oct. 15, 2013, 7:23 p.m.)
>
>
> Review request for cloudstack, Harikrishna Patnala, venkata swamy babu budumuru, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation test cases for feature - Non Contiguous VLAN ranges
> CLOUDSTACk 2238.
>
>
> Diffs
> -----
>
> test/integration/component/test_non_contiguous_vlan.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14319/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>
Re: Review Request 14319: CLOUDSTACK 2238: Automation - Non Contiguous VLAN
Ranges
Posted by Gaurav Aradhye <ga...@clogeny.com>.
> On Oct. 15, 2013, 4:08 p.m., venkata swamy babu budumuru wrote:
> > test/integration/component/test_non_contiguous_vlan.py, line 311
> > <https://reviews.apache.org/r/14319/diff/3/?file=359634#file359634line311>
> >
> > I dont see this instructions and the steps mentioned in the doc string matches. Can you please double check this test?
The test verifies that if the vlan id in a range is in use, then that vlan range can't be removed.
The test updates the vlan with a range, deploys an instance so that it automatically creates a network which uses a vlan id from the current range.
Then it tries to update vlan with different range (This is same as removing the current range). It is checked that this operation should fail.
Please let me know which step is unclear so that I can update it with appropriate comment.
> On Oct. 15, 2013, 4:08 p.m., venkata swamy babu budumuru wrote:
> > test/integration/component/test_non_contiguous_vlan.py, line 117
> > <https://reviews.apache.org/r/14319/diff/3/?file=359634#file359634line117>
> >
> > 1. Have something like "self.phy_network" instead of slf.network. This is little confusing.
> >
> > 2. This script is fetch phy network info here as well as in setNonContiguousVlanIds. Can you remove the redundancy here?
Sure, will do.
- Gaurav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14319/#review27016
-----------------------------------------------------------
On Sept. 30, 2013, 1:51 p.m., Gaurav Aradhye wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14319/
> -----------------------------------------------------------
>
> (Updated Sept. 30, 2013, 1:51 p.m.)
>
>
> Review request for cloudstack, Harikrishna Patnala, venkata swamy babu budumuru, and Prasanna Santhanam.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation test cases for feature - Non Contiguous VLAN ranges
> CLOUDSTACk 2238.
>
>
> Diffs
> -----
>
> test/integration/component/test_non_contiguous_vlan.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14319/diff/
>
>
> Testing
> -------
>
> Tested locally.
>
>
> Thanks,
>
> Gaurav Aradhye
>
>