You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2009/06/20 00:36:07 UTC
[jira] Created: (CASSANDRA-243) more commitlogheader improvement
more commitlogheader improvement
--------------------------------
Key: CASSANDRA-243
URL: https://issues.apache.org/jira/browse/CASSANDRA-243
Project: Cassandra
Issue Type: Improvement
Reporter: Jonathan Ellis
Assignee: Jonathan Ellis
see Jun's comments to CASSANDRA-237
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-243) more commitlogheader improvement
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-243:
-------------------------------------
Component/s: Core
> more commitlogheader improvement
> --------------------------------
>
> Key: CASSANDRA-243
> URL: https://issues.apache.org/jira/browse/CASSANDRA-243
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.4
>
> Attachments: 243.patch
>
>
> see Jun's comments to CASSANDRA-237
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-243) more commitlogheader improvement
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722260#action_12722260 ]
Jonathan Ellis commented on CASSANDRA-243:
------------------------------------------
This makes fixes (1) and (2) suggested by Jun.
It is better to leave (3) alone though. Added comment:
// we leave the old 'dirty' bits alone, so we can test for
// whether it's safe to remove a given log segment by and-ing its dirty
// with the current one.
testing with and() is going to be a lot faster than iterating through the bits one by one. premature optimization, perhaps, but harmless at this point.
> more commitlogheader improvement
> --------------------------------
>
> Key: CASSANDRA-243
> URL: https://issues.apache.org/jira/browse/CASSANDRA-243
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 243.patch
>
>
> see Jun's comments to CASSANDRA-237
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-243) more commitlogheader improvement
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-243:
-------------------------------------
Attachment: 243.patch
> more commitlogheader improvement
> --------------------------------
>
> Key: CASSANDRA-243
> URL: https://issues.apache.org/jira/browse/CASSANDRA-243
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 243.patch
>
>
> see Jun's comments to CASSANDRA-237
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-243) more commitlogheader improvement
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-243?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-243.
--------------------------------------
Resolution: Fixed
removed cFC and committed.
> more commitlogheader improvement
> --------------------------------
>
> Key: CASSANDRA-243
> URL: https://issues.apache.org/jira/browse/CASSANDRA-243
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 243.patch
>
>
> see Jun's comments to CASSANDRA-237
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-243) more commitlogheader improvement
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723059#action_12723059 ]
Hudson commented on CASSANDRA-243:
----------------------------------
Integrated in Cassandra #117 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/117/])
more CommitLog cleanup. patch by jbellis; reviewed by Jun Rao for
> more commitlogheader improvement
> --------------------------------
>
> Key: CASSANDRA-243
> URL: https://issues.apache.org/jira/browse/CASSANDRA-243
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 243.patch
>
>
> see Jun's comments to CASSANDRA-237
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-243) more commitlogheader improvement
Posted by "Jun Rao (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12722640#action_12722640 ]
Jun Rao commented on CASSANDRA-243:
-----------------------------------
I don't see CLH.columnFamilyCount() being used. Other than that, the patch looks good to me.
> more commitlogheader improvement
> --------------------------------
>
> Key: CASSANDRA-243
> URL: https://issues.apache.org/jira/browse/CASSANDRA-243
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Attachments: 243.patch
>
>
> see Jun's comments to CASSANDRA-237
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.