You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2020/04/21 21:05:47 UTC
[Impala-ASF-CR] Ensure the FE custom cluster tests are run in precommit
Thomas Tauber-Marshall has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15778
Change subject: Ensure the FE custom cluster tests are run in precommit
......................................................................
Ensure the FE custom cluster tests are run in precommit
Prior to this patch, in run-all-tests.sh it was required that both
CLUSTER_TEST=true and FE_TEST=true for the FE custom cluster tests to
get run.
This resulted in these tests not getting run in precommit after the
precommit job was split into two runs of separate tests, one with
FE_TEST=true and the other with CLUSTER_TEST=true.
Its probably better to maintain the invariant that all of the tests
can be run by setting each of FE_TEST, BE_TEST, etc. to true one at a
time, so this patch fixes the issue by removing the requirement that
FE_TEST=true for the FE custom cluster tests to be run.
This doesn't introduce any new dependencies since having the FE built
is a requirement for being able to run the non-FE custom cluster tests
anyways.
Change-Id: I111a7993ca6c2f986b496c489f5cf028ee0d5154
---
M bin/run-all-tests.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/15778/1
--
To view, visit http://gerrit.cloudera.org:8080/15778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I111a7993ca6c2f986b496c489f5cf028ee0d5154
Gerrit-Change-Number: 15778
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
[Impala-ASF-CR] Ensure the FE custom cluster tests are run in precommit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15778 )
Change subject: Ensure the FE custom cluster tests are run in precommit
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/5685/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/15778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I111a7993ca6c2f986b496c489f5cf028ee0d5154
Gerrit-Change-Number: 15778
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 21:07:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Ensure the FE custom cluster tests are run in precommit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15778 )
Change subject: Ensure the FE custom cluster tests are run in precommit
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/15778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I111a7993ca6c2f986b496c489f5cf028ee0d5154
Gerrit-Change-Number: 15778
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Wed, 22 Apr 2020 01:32:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Ensure the FE custom cluster tests are run in precommit
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15778 )
Change subject: Ensure the FE custom cluster tests are run in precommit
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/15778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I111a7993ca6c2f986b496c489f5cf028ee0d5154
Gerrit-Change-Number: 15778
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 21:09:35 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Ensure the FE custom cluster tests are run in precommit
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15778 )
Change subject: Ensure the FE custom cluster tests are run in precommit
......................................................................
Patch Set 1:
Thanks for fixing, I agree with the reasoning in the commit message.
--
To view, visit http://gerrit.cloudera.org:8080/15778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I111a7993ca6c2f986b496c489f5cf028ee0d5154
Gerrit-Change-Number: 15778
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 21:09:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] Ensure the FE custom cluster tests are run in precommit
Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15778 )
Change subject: Ensure the FE custom cluster tests are run in precommit
......................................................................
Ensure the FE custom cluster tests are run in precommit
Prior to this patch, in run-all-tests.sh it was required that both
CLUSTER_TEST=true and FE_TEST=true for the FE custom cluster tests to
get run.
This resulted in these tests not getting run in precommit after the
precommit job was split into two runs of separate tests, one with
FE_TEST=true and the other with CLUSTER_TEST=true.
Its probably better to maintain the invariant that all of the tests
can be run by setting each of FE_TEST, BE_TEST, etc. to true one at a
time, so this patch fixes the issue by removing the requirement that
FE_TEST=true for the FE custom cluster tests to be run.
This doesn't introduce any new dependencies since having the FE built
is a requirement for being able to run the non-FE custom cluster tests
anyways.
Change-Id: I111a7993ca6c2f986b496c489f5cf028ee0d5154
Reviewed-on: http://gerrit.cloudera.org:8080/15778
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M bin/run-all-tests.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tim Armstrong: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/15778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I111a7993ca6c2f986b496c489f5cf028ee0d5154
Gerrit-Change-Number: 15778
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] Ensure the FE custom cluster tests are run in precommit
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/15778 )
Change subject: Ensure the FE custom cluster tests are run in precommit
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/5852/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/15778
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I111a7993ca6c2f986b496c489f5cf028ee0d5154
Gerrit-Change-Number: 15778
Gerrit-PatchSet: 1
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 21:46:56 +0000
Gerrit-HasComments: No