You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by GitBox <gi...@apache.org> on 2021/03/09 06:11:50 UTC
[GitHub] [avro] dongjoon-hyun opened a new pull request #1129: AVRO-3072: Use ZSTD NoFinalizer classes and bump to 1.4.9-1
dongjoon-hyun opened a new pull request #1129:
URL: https://github.com/apache/avro/pull/1129
Make sure you have checked _all_ steps below.
### Jira
- [ ] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO/) issues and references them in the PR title. For example, "AVRO-1234: My Avro PR"
- https://issues.apache.org/jira/browse/AVRO-XXX
- In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Documentation
- [ ] In case of new functionality, my PR adds documentation that describes how to use it.
- All the public functions and the classes in the PR contain Javadoc that explain what it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba merged pull request #1129: AVRO-3072: Use ZSTD NoFinalizer classes and bump to 1.4.9-1
Posted by GitBox <gi...@apache.org>.
RyanSkraba merged pull request #1129:
URL: https://github.com/apache/avro/pull/1129
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] dongjoon-hyun commented on pull request #1129: AVRO-3072: Use ZSTD NoFinalizer classes and bump to 1.4.9-1
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #1129:
URL: https://github.com/apache/avro/pull/1129#issuecomment-794147044
Thank you! For the following, yes. They will be public always on ZSTD JNI side.
> Do we have any guarantees that this *NoFinalizer classes will continue to be public on the zstd side?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] RyanSkraba commented on pull request #1129: AVRO-3072: Use ZSTD NoFinalizer classes and bump to 1.4.9-1
Posted by GitBox <gi...@apache.org>.
RyanSkraba commented on pull request #1129:
URL: https://github.com/apache/avro/pull/1129#issuecomment-794077460
Hello! How about let's merge this to master for 1.11.x (coming out in a couple of months), and include it in an 1.10.2 RC2 if there is one. The next major version of Avro should be coming out in a couple of months, and the 1.10.2 RC1 should be binary compatible with both ZSTD 1.4.8 and 1.4.9, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] iemejia commented on pull request #1129: AVRO-3072: Use ZSTD NoFinalizer classes and bump to 1.4.9-1
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #1129:
URL: https://github.com/apache/avro/pull/1129#issuecomment-794213086
It seems we will have to do an RC2 for Avro 1.10.2 so we will do the best to cherry pick this one. The 1.4.9 version seems worth.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] dongjoon-hyun commented on pull request #1129: AVRO-3072: Use ZSTD NoFinalizer classes and bump to 1.4.9-1
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #1129:
URL: https://github.com/apache/avro/pull/1129#issuecomment-793447545
Could you review this, @Fokko and @iemejia ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] iemejia commented on pull request #1129: AVRO-3072: Use ZSTD NoFinalizer classes and bump to 1.4.9-1
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #1129:
URL: https://github.com/apache/avro/pull/1129#issuecomment-793610592
Just for awareness @dongjoon-hyun we already [started the vote to release Avro 1.10.2](https://lists.apache.org/thread.html/rf751c9ad0dc76f22ebe3a80e3144f4f242bcc972ae2c3585e65951c6%40%3Cdev.avro.apache.org%3E)
Do we have any guarantees that this *NoFinalizer classes will continue to be public on the zstd side?
Since we have to be out before downstream does I suppose that the long mode improvements won't make it into Avro 1.11.0, but that's not an issue for 1.10.2 because we align the zstd 1.4.9 dep and Spark can do it independently.
I suppose we should do a new RC to catch this. WDYT @RyanSkraba?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] iemejia commented on pull request #1129: AVRO-3072: Use ZSTD NoFinalizer classes and bump to 1.4.9-1
Posted by GitBox <gi...@apache.org>.
iemejia commented on pull request #1129:
URL: https://github.com/apache/avro/pull/1129#issuecomment-794214474
Oh already cherry picked! :+1: @RyanSkraba !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [avro] dongjoon-hyun commented on pull request #1129: AVRO-3072: Use ZSTD NoFinalizer classes and bump to 1.4.9-1
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #1129:
URL: https://github.com/apache/avro/pull/1129#issuecomment-793517067
Thank you, @RyanSkraba .
Yes, Apache Spark master branch is using 1.4.9-1 already for Apache Spark 3.2.0 release.
- https://github.com/apache/spark/commit/ba7e525a114cba01735ba94dc6d3a55dc372a2fc
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org