You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/07/26 17:19:50 UTC
[GitHub] [iceberg] kbendick opened a new pull request, #5359: AWS - Fix ErrorProne warning of malformed Javadoc
kbendick opened a new pull request, #5359:
URL: https://github.com/apache/iceberg/pull/5359
Noticed this error prone warning when checking my work for warnings.
```
> Task :iceberg-aws:compileJava
/Users/kylebendickson/repos/iceberg/aws/src/main/java/org/apache/iceberg/aws/AwsProperties.java:130: warning: [AlmostJavadoc] This comment contains Javadoc or HTML tags, but isn't started with a double asterisk (/**); is it meant to be Javadoc?
public static final String GLUE_CATALOG_ENDPOINT = "glue.endpoint";
^
(see https://errorprone.info/bugpattern/AlmostJavadoc)
Did you mean '/**'?
```
This fixes the malformed JavaDoc on the GLUE_CATALOG_ENDPOINT configuration constant.
cc @xiaoxuandev
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] kbendick commented on pull request #5359: AWS - Fix ErrorProne warning of malformed Javadoc
Posted by GitBox <gi...@apache.org>.
kbendick commented on PR #5359:
URL: https://github.com/apache/iceberg/pull/5359#issuecomment-1195763228
Sorry looked at the wrong git blame:
cc @naushadh @amogh-jahagirdar
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi merged pull request #5359: AWS - Fix ErrorProne warning of malformed Javadoc
Posted by GitBox <gi...@apache.org>.
aokolnychyi merged PR #5359:
URL: https://github.com/apache/iceberg/pull/5359
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] xiaoxuandev commented on pull request #5359: AWS - Fix ErrorProne warning of malformed Javadoc
Posted by GitBox <gi...@apache.org>.
xiaoxuandev commented on PR #5359:
URL: https://github.com/apache/iceberg/pull/5359#issuecomment-1195808930
Thanks for the fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] aokolnychyi commented on pull request #5359: AWS - Fix ErrorProne warning of malformed Javadoc
Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on PR #5359:
URL: https://github.com/apache/iceberg/pull/5359#issuecomment-1196072614
Nice catch, @kbendick!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] amogh-jahagirdar commented on pull request #5359: AWS - Fix ErrorProne warning of malformed Javadoc
Posted by GitBox <gi...@apache.org>.
amogh-jahagirdar commented on PR #5359:
URL: https://github.com/apache/iceberg/pull/5359#issuecomment-1195780076
Ah thanks for cleaning this up! LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org