You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/07/02 21:00:36 UTC
[GitHub] [incubator-mxnet] szha opened a new pull request #18656: [NumPy] DLPack refactor and npx.from_numpy
szha opened a new pull request #18656:
URL: https://github.com/apache/incubator-mxnet/pull/18656
## Description ##
Refactor DLPack functionality and add npx.from_numpy
## Checklist ##
### Essentials ###
Please feel free to remove inapplicable items for your PR.
- [x] All changes have test coverage:
- Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
- [x] Code is well-documented:
- For user-facing API changes, API doc string has been updated.
- [x] To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
### Changes ###
- [x] refactor DLPack API
- [x] npx.from_numpy
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #18656: [NumPy] DLPack refactor and npx.from_numpy
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #18656:
URL: https://github.com/apache/incubator-mxnet/pull/18656#discussion_r463281160
##########
File path: tests/python/unittest/test_numpy_ndarray.py
##########
@@ -1369,3 +1369,31 @@ def test_dlpack(dtype, size):
same(a_np+1, b)
same(a_np+2, c)
same(a_np+2, a_copy)
+
+@use_np
+@pytest.mark.parametrize('np_array', [
+ # ordinary numpy array
+ _np.array([[1, 2], [3, 4], [5, 6]], dtype="float32"),
+ # 0-dim
+ _np.array((1, )).reshape(()),
+ # 0-size
+ _np.array(()).reshape((1, 0, 2)),
+])
+@pytest.mark.parametrize('zero_copy', [False, True])
+def test_from_numpy(np_array, zero_copy):
+ # Test zero_copy
+ mx_array = mx.npx.from_numpy(np_array, zero_copy=zero_copy)
+ mx.test_utils.assert_almost_equal(np_array, mx_array.asnumpy())
+
+def test_from_numpy_exception():
+ np_array = _np.array([[1, 2], [3, 4], [5, 6]], dtype="float32")
+ mx_array = mx.npx.from_numpy(np_array)
+ with pytest.raises(ValueError):
+ np_array[2, 1] = 0
Review comment:
already covered in another test a few lines up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha commented on a change in pull request #18656: [NumPy] DLPack refactor and npx.from_numpy
Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #18656:
URL: https://github.com/apache/incubator-mxnet/pull/18656#discussion_r463281160
##########
File path: tests/python/unittest/test_numpy_ndarray.py
##########
@@ -1369,3 +1369,31 @@ def test_dlpack(dtype, size):
same(a_np+1, b)
same(a_np+2, c)
same(a_np+2, a_copy)
+
+@use_np
+@pytest.mark.parametrize('np_array', [
+ # ordinary numpy array
+ _np.array([[1, 2], [3, 4], [5, 6]], dtype="float32"),
+ # 0-dim
+ _np.array((1, )).reshape(()),
+ # 0-size
+ _np.array(()).reshape((1, 0, 2)),
+])
+@pytest.mark.parametrize('zero_copy', [False, True])
+def test_from_numpy(np_array, zero_copy):
+ # Test zero_copy
+ mx_array = mx.npx.from_numpy(np_array, zero_copy=zero_copy)
+ mx.test_utils.assert_almost_equal(np_array, mx_array.asnumpy())
+
+def test_from_numpy_exception():
+ np_array = _np.array([[1, 2], [3, 4], [5, 6]], dtype="float32")
+ mx_array = mx.npx.from_numpy(np_array)
+ with pytest.raises(ValueError):
+ np_array[2, 1] = 0
Review comment:
already covered in another test a few lines up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18656: [NumPy] DLPack refactor and npx.from_numpy
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18656:
URL: https://github.com/apache/incubator-mxnet/pull/18656#issuecomment-653218167
Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [unix-cpu, miscellaneous, unix-gpu, website, centos-cpu, edge, clang, sanity, centos-gpu, windows-gpu, windows-cpu]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] leezu commented on a change in pull request #18656: [NumPy] DLPack refactor and npx.from_numpy
Posted by GitBox <gi...@apache.org>.
leezu commented on a change in pull request #18656:
URL: https://github.com/apache/incubator-mxnet/pull/18656#discussion_r463265822
##########
File path: tests/python/unittest/test_numpy_ndarray.py
##########
@@ -1369,3 +1369,31 @@ def test_dlpack(dtype, size):
same(a_np+1, b)
same(a_np+2, c)
same(a_np+2, a_copy)
+
+@use_np
+@pytest.mark.parametrize('np_array', [
+ # ordinary numpy array
+ _np.array([[1, 2], [3, 4], [5, 6]], dtype="float32"),
+ # 0-dim
+ _np.array((1, )).reshape(()),
+ # 0-size
+ _np.array(()).reshape((1, 0, 2)),
+])
+@pytest.mark.parametrize('zero_copy', [False, True])
+def test_from_numpy(np_array, zero_copy):
+ # Test zero_copy
+ mx_array = mx.npx.from_numpy(np_array, zero_copy=zero_copy)
+ mx.test_utils.assert_almost_equal(np_array, mx_array.asnumpy())
+
+def test_from_numpy_exception():
+ np_array = _np.array([[1, 2], [3, 4], [5, 6]], dtype="float32")
+ mx_array = mx.npx.from_numpy(np_array)
+ with pytest.raises(ValueError):
+ np_array[2, 1] = 0
Review comment:
Test that no exception is thrown if `zero_copy=False`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-mxnet] szha merged pull request #18656: [NumPy] DLPack refactor and npx.from_numpy
Posted by GitBox <gi...@apache.org>.
szha merged pull request #18656:
URL: https://github.com/apache/incubator-mxnet/pull/18656
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org