[GitHub] [superset] justinpark commented on pull request #24787: feat(sqllab): Show sql in the current result

["justinpark (via GitHub)" <gi...@apache.org>]

justinpark commented on PR #24787:
URL: https://github.com/apache/superset/pull/24787#issuecomment-1666193471

   > I have a few suggestions:
   
   > in other places in the app we actually have a number of rows or the right side of the table and filters/title etc on the left side; I think it would make sense to switch the order in here too, because the sql line acts as a title. Below a screenshot for reference (from explore)
   > image
   > The sql field could have a max width and if the text (first line) doesn't fill that space, the sql input could shrink a little bit
   > 
   > if there is another line, more text that is longer than the max width of the container (as Michael said) there should be a truncation rule with "..." - this is a default truncation behavior we use across the app
   
   @kasiazjc I updated the layout as you suggested. I also replaces the existing limit message by the tooltip (+ exclamation indicator when exists). Feel free to give any feedback at your convenience.
   
   
   https://github.com/apache/superset/assets/1392866/80a73d05-0534-48ea-a7f5-2691578275bc
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org