You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/02/24 12:14:57 UTC
[GitHub] [incubator-pekko-grpc] pjfanning opened a new pull request, #23: [DRAFT] uptake pekko jars, use pekko names in packages and configs
pjfanning opened a new pull request, #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23
* a long way from complete
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#discussion_r1119202597
##########
docs/src/main/paradox/client/details.md:
##########
@@ -24,15 +24,15 @@ will complete with a failure when the maximum number of `connectionAttempts` (wh
By default, each instance of a generated client creates a separate HTTP connection to the server. If the server
supports multiple services, you may want to allow multiple generated clients to share a single connection.
-To do this, create a @apidoc[GrpcChannel] by passing @apidoc[GrpcClientSettings] to the apply method. You can then
Review Comment:
Why is `@apidoc` being removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#issuecomment-1447109687
Jabba will probably start working again. I can do a separate PR for setup-java switch. I can do that now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#discussion_r1119248535
##########
docs/src/main/paradox/client/details.md:
##########
@@ -24,15 +24,15 @@ will complete with a failure when the maximum number of `connectionAttempts` (wh
By default, each instance of a generated client creates a separate HTTP connection to the server. If the server
supports multiple services, you may want to allow multiple generated clients to share a single connection.
-To do this, create a @apidoc[GrpcChannel] by passing @apidoc[GrpcClientSettings] to the apply method. You can then
Review Comment:
So I can verify if you modify `apidocRootPackage` on line 210 of `build.sbt` to `"org.apache.pekko"` then `@apidoc` works as expected (verified locally by doing `pekko-grpc-docs/paradox`). Also you need to change line 9 of `docs/src/main/paradox/deploy.md` from `@apidoc[akka.http.(javadsl|scaladsl).HttpsConnectionContext]` to `@apidoc[org.apache.pekko.http.(javadsl|scaladsl).HttpsConnectionContext]`
I think its easier if you revert that commit and apply this fix, alternately I can just add the commit to fix this onto this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on pull request #23: uptake pekko jars, use pekko names in packages and configs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#issuecomment-1446442439
The cors code in pekko-grpc does look like it is non-trivial to rip out (and later add back) - so we might be best off waiting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#discussion_r1119237604
##########
docs/src/main/paradox/client/details.md:
##########
@@ -24,15 +24,15 @@ will complete with a failure when the maximum number of `connectionAttempts` (wh
By default, each instance of a generated client creates a separate HTTP connection to the server. If the server
supports multiple services, you may want to allow multiple generated clients to share a single connection.
-To do this, create a @apidoc[GrpcChannel] by passing @apidoc[GrpcClientSettings] to the apply method. You can then
Review Comment:
I will just quickly verify whether `apidocRootPackage` is the cause of the problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#issuecomment-1446861411
I merged @jrudolph change. I'm happy to have this merged if the consensus is that we can look at adding back the CORS support in a few weeks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#issuecomment-1447107170
Yeah so everything related to JDK 11 is failing because of
```
- name: Set up JDK 11
uses: olafurpg/setup-scala@v13
with:
java-version: adopt@1.11
```
If we change this to `setup-java` instead of `setup-scala` (like we did with pekko) this should solve the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning merged pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #23: uptake pekko jars, use pekko names in packages and configs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#issuecomment-1446430928
Another option would be to wait a couple of weeks, the owner of `akka-http-cors` did say they are going to migrate over to pekko and since the `akka-http-cors` is pretty trivial it shouldn't be too problematic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#discussion_r1119386573
##########
interop-tests/src/test/scala/org/apache/pekko/grpc/interop/GrpcInteropSpec.scala:
##########
@@ -0,0 +1,73 @@
+/*
+ * Copyright (C) 2018-2021 Lightbend Inc. <https://www.lightbend.com>
+ */
+
+package org.apache.pekko.grpc.interop
+
+import io.grpc.testing.integration.TestServiceHandlerFactory
+
+class GrpcInteropIoWithIoSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.IoGrpc)
+class GrpcInteropIoWithAkkaNettyScalaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaNetty.Scala)
+class GrpcInteropIoWithAkkaNettyJavaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaNetty.Java)
+class GrpcInteropIoWithAkkaHttpScalaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaHttp.Scala)
+//class GrpcInteropIoWithAkkaHttpJavaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaHttp.Java)
+
+class GrpcInteropPekkoScalaWithIoSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.IoGrpc)
+class GrpcInteropPekkoScalaWithAkkaNettyScalaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaNetty.Scala)
+class GrpcInteropPekkoScalaWithAkkaNettyJavaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaNetty.Java)
+class GrpcInteropPekkoScalaWithAkkaHttpScalaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaHttp.Scala)
+//class GrpcInteropPekkoScalaWithAkkaHttpJavaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaHttp.Java)
+
+class GrpcInteropPekkoJavaWithIoSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.IoGrpc)
+class GrpcInteropPekkoJavaWithAkkaNettyScalaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaNetty.Scala)
+class GrpcInteropPekkoJavaWithAkkaNettyJavaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaNetty.Java)
+class GrpcInteropPekkoJavaWithAkkaHttpScalaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaHttp.Scala)
+//class GrpcInteropPekkoJavaWithAkkaHttpJavaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaHttp.Java)
+
+//--- Aliases
+
+object Servers {
+ val IoGrpc = IoGrpcJavaServerProvider
+ object Akka {
Review Comment:
No worries, PR is approved anyways so its ready to merge when you are happy with it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#issuecomment-1447103653
Hmm, the jabba issues seem completely unrelated, jabba is used in `setup-java` github action just to download JDK. Let me see
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] jrudolph commented on pull request #23: uptake pekko jars, use pekko names in packages and configs
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#issuecomment-1446422947
> > * temporarily added akka-http-cors in this repo because that lib does not yet support pekko - but soon will
>
> Isn't that a blocker for merging this PR for now? Feels wrong to add third-party code as part of such a big commit just to get everything working right now.
If we would really want to add it to this project, we would have change its package name to avoid future problems for users which use both pekko-http-cors and pekko-grpc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#issuecomment-1446874628
> * reintroduce dependency on akka-http-cors (or pekko equivalent) #22
There is #22
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] jrudolph commented on pull request #23: [DRAFT] uptake pekko jars, use pekko names in packages and configs
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#issuecomment-1446488665
> The cors code in pekko-grpc does look like it is non-trivial to rip out (and later add back) - so we might be best off waiting
Was easy enough, I added it here: https://github.com/pjfanning/incubator-pekko-grpc/pull/1. This might break something but it's only used in grpc-web which is less used than regular grpc support. I don't mind waiting for cors support, on the other hand, getting a snapshot version out which mostly works besides grpc-web/cors support might still be interesting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#discussion_r1119234781
##########
docs/src/main/paradox/client/details.md:
##########
@@ -24,15 +24,15 @@ will complete with a failure when the maximum number of `connectionAttempts` (wh
By default, each instance of a generated client creates a separate HTTP connection to the server. If the server
supports multiple services, you may want to allow multiple generated clients to share a single connection.
-To do this, create a @apidoc[GrpcChannel] by passing @apidoc[GrpcClientSettings] to the apply method. You can then
Review Comment:
#25 is open and probably can only be fixed as part of #26
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#discussion_r1119248535
##########
docs/src/main/paradox/client/details.md:
##########
@@ -24,15 +24,15 @@ will complete with a failure when the maximum number of `connectionAttempts` (wh
By default, each instance of a generated client creates a separate HTTP connection to the server. If the server
supports multiple services, you may want to allow multiple generated clients to share a single connection.
-To do this, create a @apidoc[GrpcChannel] by passing @apidoc[GrpcClientSettings] to the apply method. You can then
Review Comment:
So I can verify if you modify `apidocRootPackage` on line 210 of `build.sbt` to `"org.apache.pekko"` then `@apidoc` works as expected (verified locally by doing `pekko-grpc-docs/paradox`). Also you need to change line 9 of `docs/src/main/paradox/deploy.md` from `@apidoc[akka.http.(javadsl|scaladsl).HttpsConnectionContext]` to `@apidoc[org.apache.pekko.http.(javadsl|scaladsl).HttpsConnectionContext]`
I think its easier if you revert the commit that removes `@apidoc` and apply this fix rather than worrying about it later, alternately I can just add the commit to fix this onto this branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#issuecomment-1447101143
I've tried out the apidoc changes but CI is struggling due to Jabba connectivity issues
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on a diff in pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on code in PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#discussion_r1119367381
##########
interop-tests/src/test/scala/org/apache/pekko/grpc/interop/GrpcInteropSpec.scala:
##########
@@ -0,0 +1,73 @@
+/*
+ * Copyright (C) 2018-2021 Lightbend Inc. <https://www.lightbend.com>
+ */
+
+package org.apache.pekko.grpc.interop
+
+import io.grpc.testing.integration.TestServiceHandlerFactory
+
+class GrpcInteropIoWithIoSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.IoGrpc)
+class GrpcInteropIoWithAkkaNettyScalaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaNetty.Scala)
+class GrpcInteropIoWithAkkaNettyJavaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaNetty.Java)
+class GrpcInteropIoWithAkkaHttpScalaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaHttp.Scala)
+//class GrpcInteropIoWithAkkaHttpJavaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaHttp.Java)
+
+class GrpcInteropPekkoScalaWithIoSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.IoGrpc)
+class GrpcInteropPekkoScalaWithAkkaNettyScalaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaNetty.Scala)
+class GrpcInteropPekkoScalaWithAkkaNettyJavaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaNetty.Java)
+class GrpcInteropPekkoScalaWithAkkaHttpScalaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaHttp.Scala)
+//class GrpcInteropPekkoScalaWithAkkaHttpJavaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaHttp.Java)
+
+class GrpcInteropPekkoJavaWithIoSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.IoGrpc)
+class GrpcInteropPekkoJavaWithAkkaNettyScalaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaNetty.Scala)
+class GrpcInteropPekkoJavaWithAkkaNettyJavaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaNetty.Java)
+class GrpcInteropPekkoJavaWithAkkaHttpScalaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaHttp.Scala)
+//class GrpcInteropPekkoJavaWithAkkaHttpJavaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaHttp.Java)
+
+//--- Aliases
+
+object Servers {
+ val IoGrpc = IoGrpcJavaServerProvider
+ object Akka {
Review Comment:
I just noticed that this file still has clases/types with the `Akka` name in it, since the PR changes class names as well shall change it here as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#issuecomment-1446864151
Fine with me, just make an issue for it so we don't forget
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] mdedetrich commented on pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#issuecomment-1447141297
> Jabba will probably start working again. I can do a separate PR for setup-java switch. I can do that now.
I think it makes sense to do it now, its a trivial PR and needs to be done anyways (`setup-scala` as we can see has problems).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #23: Uptake pekko jars, use pekko names in packages and configs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#discussion_r1119374422
##########
interop-tests/src/test/scala/org/apache/pekko/grpc/interop/GrpcInteropSpec.scala:
##########
@@ -0,0 +1,73 @@
+/*
+ * Copyright (C) 2018-2021 Lightbend Inc. <https://www.lightbend.com>
+ */
+
+package org.apache.pekko.grpc.interop
+
+import io.grpc.testing.integration.TestServiceHandlerFactory
+
+class GrpcInteropIoWithIoSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.IoGrpc)
+class GrpcInteropIoWithAkkaNettyScalaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaNetty.Scala)
+class GrpcInteropIoWithAkkaNettyJavaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaNetty.Java)
+class GrpcInteropIoWithAkkaHttpScalaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaHttp.Scala)
+//class GrpcInteropIoWithAkkaHttpJavaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaHttp.Java)
+
+class GrpcInteropPekkoScalaWithIoSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.IoGrpc)
+class GrpcInteropPekkoScalaWithAkkaNettyScalaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaNetty.Scala)
+class GrpcInteropPekkoScalaWithAkkaNettyJavaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaNetty.Java)
+class GrpcInteropPekkoScalaWithAkkaHttpScalaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaHttp.Scala)
+//class GrpcInteropPekkoScalaWithAkkaHttpJavaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaHttp.Java)
+
+class GrpcInteropPekkoJavaWithIoSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.IoGrpc)
+class GrpcInteropPekkoJavaWithAkkaNettyScalaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaNetty.Scala)
+class GrpcInteropPekkoJavaWithAkkaNettyJavaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaNetty.Java)
+class GrpcInteropPekkoJavaWithAkkaHttpScalaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaHttp.Scala)
+//class GrpcInteropPekkoJavaWithAkkaHttpJavaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaHttp.Java)
+
+//--- Aliases
+
+object Servers {
+ val IoGrpc = IoGrpcJavaServerProvider
+ object Akka {
Review Comment:
I updated this instance - there are still planty of Akka refs in docs, etc. - and it may be better to leave the other instances until another PR to avoid this one becoming too large
##########
interop-tests/src/test/scala/org/apache/pekko/grpc/interop/GrpcInteropSpec.scala:
##########
@@ -0,0 +1,73 @@
+/*
+ * Copyright (C) 2018-2021 Lightbend Inc. <https://www.lightbend.com>
+ */
+
+package org.apache.pekko.grpc.interop
+
+import io.grpc.testing.integration.TestServiceHandlerFactory
+
+class GrpcInteropIoWithIoSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.IoGrpc)
+class GrpcInteropIoWithAkkaNettyScalaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaNetty.Scala)
+class GrpcInteropIoWithAkkaNettyJavaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaNetty.Java)
+class GrpcInteropIoWithAkkaHttpScalaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaHttp.Scala)
+//class GrpcInteropIoWithAkkaHttpJavaSpec extends GrpcInteropTests(Servers.IoGrpc, Clients.AkkaHttp.Java)
+
+class GrpcInteropPekkoScalaWithIoSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.IoGrpc)
+class GrpcInteropPekkoScalaWithAkkaNettyScalaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaNetty.Scala)
+class GrpcInteropPekkoScalaWithAkkaNettyJavaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaNetty.Java)
+class GrpcInteropPekkoScalaWithAkkaHttpScalaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaHttp.Scala)
+//class GrpcInteropPekkoScalaWithAkkaHttpJavaSpec extends GrpcInteropTests(Servers.Akka.Scala, Clients.AkkaHttp.Java)
+
+class GrpcInteropPekkoJavaWithIoSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.IoGrpc)
+class GrpcInteropPekkoJavaWithAkkaNettyScalaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaNetty.Scala)
+class GrpcInteropPekkoJavaWithAkkaNettyJavaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaNetty.Java)
+class GrpcInteropPekkoJavaWithAkkaHttpScalaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaHttp.Scala)
+//class GrpcInteropPekkoJavaWithAkkaHttpJavaSpec extends GrpcInteropTests(Servers.Akka.Java, Clients.AkkaHttp.Java)
+
+//--- Aliases
+
+object Servers {
+ val IoGrpc = IoGrpcJavaServerProvider
+ object Akka {
Review Comment:
I updated this instance - there are still plenty of Akka refs in docs, etc. - and it may be better to leave the other instances until another PR to avoid this one becoming too large
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] jrudolph commented on pull request #23: uptake pekko jars, use pekko names in packages and configs
Posted by "jrudolph (via GitHub)" <gi...@apache.org>.
jrudolph commented on PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#issuecomment-1446417775
Great stuff!
> * temporarily added akka-http-cors in this repo because that lib does not yet support pekko - but soon will
Isn't that a blocker for merging this PR for now? Feels wrong to add third-party code in such a big commit just to get everything working right now.
How about we just disable cors support for now to make this PR mergable (it's only used in four lines in the code) and then decide afterwards if we want to temporarily enable by importing the third-party project in its own PR or wait until the project itself has released something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on pull request #23: uptake pekko jars, use pekko names in packages and configs
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#issuecomment-1446423821
I guess I had the pekko version of akka-http-cors ready so it seemed easiest to use it but I can look at disabling cors support instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org