You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/02 07:19:21 UTC

[GitHub] [incubator-shardingsphere] TaoZhiMLND opened a new pull request #5045: revise doc for making keyGenerateAlgorithm as a spring bean.

TaoZhiMLND opened a new pull request #5045: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5045
 
 
   Fixes #5041.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls edited a comment on issue #5045: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on issue #5045: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5045#issuecomment-607683449
 
 
   ## Pull Request Test Coverage Report for [Build 10804](https://coveralls.io/builds/29801703)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **57.63%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29801703/badge)](https://coveralls.io/builds/29801703) |
   | :-- | --: |
   | Change from base [Build 9591](https://coveralls.io/builds/28768784): |  0.0% |
   | Covered Lines: | 11076 |
   | Relevant Lines: | 19219 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] TaoZhiMLND commented on a change in pull request #5045: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.
TaoZhiMLND commented on a change in pull request #5045: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5045#discussion_r402421906
 
 

 ##########
 File path: docs/document/content/manual/sharding-jdbc/configuration/config-java.cn.md
 ##########
 @@ -285,15 +285,22 @@ ShardingStrategyConfiguration的实现类，用于配置不分片的策略。
 
 #### KeyGeneratorConfiguration
 
-| *名称*             | *数据类型*                    | *说明*                                                                         |
-| ----------------- | ---------------------------- | ------------------------------------------------------------------------------ |
-| column            | String                       | 自增列名称                                                                      |
-| type              | String                       | 自增列值生成器类型，可自定义或选择内置类型：SNOWFLAKE/UUID/LEAF_SEGMENT/LEAF_SNOWFLAKE|
-| props             | Properties                   | 自增列值生成器的相关属性配置                                                      |  
+| *名称*                 | *数据类型*                    | *说明*                                                                         |
+| --------------------- | ---------------------------- | ------------------------------------------------------------------------------ |
+| column                | String                       | 自增列名称                                                                      |
+| keyGenerateAlgorithm  | KeyGenerateAlgorithm         | 自增列值生成算法                                                                 |
+
+#### KeyGenerateAlgorithm 
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #5045: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on a change in pull request #5045: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5045#discussion_r402350557
 
 

 ##########
 File path: docs/document/content/manual/sharding-jdbc/configuration/config-java.cn.md
 ##########
 @@ -285,15 +285,22 @@ ShardingStrategyConfiguration的实现类，用于配置不分片的策略。
 
 #### KeyGeneratorConfiguration
 
-| *名称*             | *数据类型*                    | *说明*                                                                         |
-| ----------------- | ---------------------------- | ------------------------------------------------------------------------------ |
-| column            | String                       | 自增列名称                                                                      |
-| type              | String                       | 自增列值生成器类型，可自定义或选择内置类型：SNOWFLAKE/UUID/LEAF_SEGMENT/LEAF_SNOWFLAKE|
-| props             | Properties                   | 自增列值生成器的相关属性配置                                                      |  
+| *名称*                 | *数据类型*                    | *说明*                                                                         |
+| --------------------- | ---------------------------- | ------------------------------------------------------------------------------ |
+| column                | String                       | 自增列名称                                                                      |
+| keyGenerateAlgorithm  | KeyGenerateAlgorithm         | 自增列值生成算法                                                                 |
+
+#### KeyGenerateAlgorithm 
 
 Review comment:
   explain of KeyGenerateAlgorithm could be removed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io edited a comment on issue #5045: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #5045: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5045#issuecomment-607680074
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5045?src=pr&el=h1) Report
   > Merging [#5045](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5045?src=pr&el=desc) into [docs5.x](https://codecov.io/gh/apache/incubator-shardingsphere/commit/415817e3bcc09c96114341adf5026ad2b06e0fbc&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5045/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5045?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##             docs5.x    #5045   +/-   ##
   ==========================================
     Coverage      54.16%   54.16%           
     Complexity       352      352           
   ==========================================
     Files           1045     1045           
     Lines          19219    19219           
     Branches        3531     3531           
   ==========================================
     Hits           10410    10410           
     Misses          8153     8153           
     Partials         656      656           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5045?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5045?src=pr&el=footer). Last update [415817e...f544022](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5045?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] TaoZhiMLND closed pull request #5045: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.
TaoZhiMLND closed pull request #5045: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5045
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] coveralls commented on issue #5045: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5045: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5045#issuecomment-607683449
 
 
   ## Pull Request Test Coverage Report for [Build 10789](https://coveralls.io/builds/29789576)
   
   * **0** of **0**   changed or added relevant lines in **0** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage remained the same at **57.63%**
   
   ---
   
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/29789576/badge)](https://coveralls.io/builds/29789576) |
   | :-- | --: |
   | Change from base [Build 9591](https://coveralls.io/builds/28768784): |  0.0% |
   | Covered Lines: | 11076 |
   | Relevant Lines: | 19219 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] codecov-io commented on issue #5045: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #5045: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5045#issuecomment-607680074
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5045?src=pr&el=h1) Report
   > Merging [#5045](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5045?src=pr&el=desc) into [docs5.x](https://codecov.io/gh/apache/incubator-shardingsphere/commit/415817e3bcc09c96114341adf5026ad2b06e0fbc&el=desc) will **not change** coverage by `%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5045/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5045?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##             docs5.x    #5045   +/-   ##
   ==========================================
     Coverage      54.16%   54.16%           
     Complexity       352      352           
   ==========================================
     Files           1045     1045           
     Lines          19219    19219           
     Branches        3531     3531           
   ==========================================
     Hits           10410    10410           
     Misses          8153     8153           
     Partials         656      656           
   ```
   
   
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5045?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5045?src=pr&el=footer). Last update [415817e...987d0cb](https://codecov.io/gh/apache/incubator-shardingsphere/pull/5045?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] TaoZhiMLND commented on a change in pull request #5045: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.
TaoZhiMLND commented on a change in pull request #5045: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5045#discussion_r402421930
 
 

 ##########
 File path: docs/document/content/manual/sharding-jdbc/configuration/config-java.en.md
 ##########
 @@ -279,15 +279,22 @@ The implementation class of `ShardingStrategyConfiguration`, used to configure n
 
 #### KeyGeneratorConfiguration
 
-| *Name*            | *DataType*                   | *Description*                                                                               |
-| ----------------- | ---------------------------- | ------------------------------------------------------------------------------------------- |
-| column            | String                       | Column name of key generator                                                                |
-| type              | String                       | Type of key generator, use user-defined ones or built-in ones, e.g. SNOWFLAKE, UUID, LEAF_SEGMENT, LEAF_SNOWFLAKE |
-| props             | Properties                   | The Property configuration of key generators                                                 |
+| *Name*                   | *DataType*               | *Description*                                                |
+| ------------------------ | ------------------------ | ------------------------------------------------------------ |
+| column                   | String                   | Column name of key generator                                 |
+| keyGenerateAlgorithm     | KeyGenerateAlgorithm     | key generate algorithm                                       |
+
+#### KeyGenerateAlgorithm
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-shardingsphere] cherrylzhao commented on a change in pull request #5045: revise doc for making keyGenerateAlgorithm as a spring bean.

Posted by GitBox <gi...@apache.org>.
cherrylzhao commented on a change in pull request #5045: revise doc for making keyGenerateAlgorithm as a spring bean.
URL: https://github.com/apache/incubator-shardingsphere/pull/5045#discussion_r402362416
 
 

 ##########
 File path: docs/document/content/manual/sharding-jdbc/configuration/config-java.en.md
 ##########
 @@ -279,15 +279,22 @@ The implementation class of `ShardingStrategyConfiguration`, used to configure n
 
 #### KeyGeneratorConfiguration
 
-| *Name*            | *DataType*                   | *Description*                                                                               |
-| ----------------- | ---------------------------- | ------------------------------------------------------------------------------------------- |
-| column            | String                       | Column name of key generator                                                                |
-| type              | String                       | Type of key generator, use user-defined ones or built-in ones, e.g. SNOWFLAKE, UUID, LEAF_SEGMENT, LEAF_SNOWFLAKE |
-| props             | Properties                   | The Property configuration of key generators                                                 |
+| *Name*                   | *DataType*               | *Description*                                                |
+| ------------------------ | ------------------------ | ------------------------------------------------------------ |
+| column                   | String                   | Column name of key generator                                 |
+| keyGenerateAlgorithm     | KeyGenerateAlgorithm     | key generate algorithm                                       |
+
+#### KeyGenerateAlgorithm
 
 Review comment:
   explain of KeyGenerateAlgorithm could be removed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services