You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/03/24 02:21:31 UTC
[GitHub] [spark] Yikun opened a new pull request #35955: [SPARK-38561][K8S][DOCS][3.3] Add doc for `Customized Kubernetes Schedulers`
Yikun opened a new pull request #35955:
URL: https://github.com/apache/spark/pull/35955
### What changes were proposed in this pull request?
This is PR to doc for basic framework capability for Customized Kubernetes Schedulers.
### Why are the changes needed?
Guide user how to use spark on kubernetes custom scheduler
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #35955: [SPARK-38561][K8S][DOCS][3.3] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #35955:
URL: https://github.com/apache/spark/pull/35955#discussion_r833874224
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1713,6 +1713,25 @@ spec:
image: will-be-overwritten
```
+#### Customized Kubernetes Schedulers for Spark on Kubernetes
+
+Spark allows users to specify a custom Kubernetes schedulers.
+
+1. Specify scheduler name.
+
+ Users can specify a custom scheduler using <code>spark.kubernetes.scheduler.name</code> or
+ <code>spark.kubernetes.{driver/executor}.scheduler.name</code> configuration.
+
+2. Specify scheduler related configurations.
+
+ To configure the custom scheduler the user can use [Pod templates](#pod-template), add labels (<code>spark.kubernetes.{driver,executor}.label.*</code>) and/or annotations (<code>spark.kubernetes.{driver/executor}.annotation.*</code>).
Review comment:
I guess this has been included by doc of feature step section? https://github.com/apache/spark/pull/35955#discussion_r833873923
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35955: [SPARK-38561][K8S][DOCS][3.3] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35955:
URL: https://github.com/apache/spark/pull/35955#discussion_r833871007
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1713,6 +1713,25 @@ spec:
image: will-be-overwritten
```
+#### Customized Kubernetes Schedulers for Spark on Kubernetes
+
+Spark allows users to specify a custom Kubernetes schedulers.
+
+1. Specify scheduler name.
+
+ Users can specify a custom scheduler using <code>spark.kubernetes.scheduler.name</code> or
+ <code>spark.kubernetes.{driver/executor}.scheduler.name</code> configuration.
+
+2. Specify scheduler related configurations.
+
+ To configure the custom scheduler the user can use [Pod templates](#pod-template), add labels (<code>spark.kubernetes.{driver,executor}.label.*</code>) and/or annotations (<code>spark.kubernetes.{driver/executor}.annotation.*</code>).
Review comment:
Hmm. It seems that you missed the most important example, `PodGroupTemplate`, here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #35955: [SPARK-38561][K8S][DOCS][3.3] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #35955:
URL: https://github.com/apache/spark/pull/35955
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #35955: [SPARK-38561][K8S][DOCS][3.3] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35955:
URL: https://github.com/apache/spark/pull/35955#issuecomment-1082524573
@dongjoon-hyun Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35955: [SPARK-38561][K8S][DOCS][3.3] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35955:
URL: https://github.com/apache/spark/pull/35955#discussion_r833870403
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1713,6 +1713,25 @@ spec:
image: will-be-overwritten
```
+#### Customized Kubernetes Schedulers for Spark on Kubernetes
+
+Spark allows users to specify a custom Kubernetes schedulers.
+
+1. Specify scheduler name.
+
+ Users can specify a custom scheduler using <code>spark.kubernetes.scheduler.name</code> or
+ <code>spark.kubernetes.{driver/executor}.scheduler.name</code> configuration.
Review comment:
`{driver/executor}` -> `{driver|executor}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #35955: [SPARK-38561][K8S][DOCS][3.3] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35955:
URL: https://github.com/apache/spark/pull/35955#issuecomment-1081652797
Address comments, also sync changes on master: https://github.com/apache/spark/pull/36001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #35955: [SPARK-38561][K8S][DOCS][3.3] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #35955:
URL: https://github.com/apache/spark/pull/35955#discussion_r837262685
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1713,6 +1713,25 @@ spec:
image: will-be-overwritten
```
+#### Customized Kubernetes Schedulers for Spark on Kubernetes
+
+Spark allows users to specify a custom Kubernetes schedulers.
+
+1. Specify scheduler name.
+
+ Users can specify a custom scheduler using <code>spark.kubernetes.scheduler.name</code> or
+ <code>spark.kubernetes.{driver/executor}.scheduler.name</code> configuration.
+
+2. Specify scheduler related configurations.
+
+ To configure the custom scheduler the user can use [Pod templates](#pod-template), add labels (<code>spark.kubernetes.{driver,executor}.label.*</code>) and/or annotations (<code>spark.kubernetes.{driver/executor}.annotation.*</code>).
Review comment:
I also add a note for `PodGroupTemplate`, : )
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on a change in pull request #35955: [SPARK-38561][K8S][DOCS][3.3] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
Yikun commented on a change in pull request #35955:
URL: https://github.com/apache/spark/pull/35955#discussion_r833873923
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1713,6 +1713,25 @@ spec:
image: will-be-overwritten
```
+#### Customized Kubernetes Schedulers for Spark on Kubernetes
+
+Spark allows users to specify a custom Kubernetes schedulers.
+
+1. Specify scheduler name.
+
+ Users can specify a custom scheduler using <code>spark.kubernetes.scheduler.name</code> or
+ <code>spark.kubernetes.{driver/executor}.scheduler.name</code> configuration.
+
+2. Specify scheduler related configurations.
+
+ To configure the custom scheduler the user can use [Pod templates](#pod-template), add labels (<code>spark.kubernetes.{driver,executor}.label.*</code>) and/or annotations (<code>spark.kubernetes.{driver/executor}.annotation.*</code>).
+
+3. Specify scheduler feature step.
+
+ Users may also consider to use <code>spark.kubernetes.{driver/executor}.pod.featureSteps</code> to support more complex requirements, including but not limited to:
+ - Create additional Kubernetes custom resources for driver/executor scheduling.
+ - Set scheduler hints according to configuration or existing Pod info dynamically.
Review comment:
> Set scheduler hints according to configuration
create pg (contains scheduler hints) according to `PodGroupTemplate`
> existing Pod info dynamically.
such as we can set priority according driver.priority, of course, it didn't use it in volcano current implementations
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35955: [SPARK-38561][K8S][DOCS][3.3] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35955:
URL: https://github.com/apache/spark/pull/35955#discussion_r833870072
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1713,6 +1713,25 @@ spec:
image: will-be-overwritten
```
+#### Customized Kubernetes Schedulers for Spark on Kubernetes
+
+Spark allows users to specify a custom Kubernetes schedulers.
+
+1. Specify scheduler name.
Review comment:
`Specify` -> `Specify a`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun edited a comment on pull request #35955: [SPARK-38561][K8S][DOCS][3.3] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
Yikun edited a comment on pull request #35955:
URL: https://github.com/apache/spark/pull/35955#issuecomment-1081652797
All comments addressed, also sync changes on master: https://github.com/apache/spark/pull/36001
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Yikun commented on pull request #35955: [SPARK-38561][K8S][DOCS][3.3] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
Yikun commented on pull request #35955:
URL: https://github.com/apache/spark/pull/35955#issuecomment-1081361379
@dongjoon-hyun @holdenk Would you mind take a look again on this? the doc for Customized Kubernetes Schedulers for 3.3 branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35955: [SPARK-38561][K8S][DOCS][3.3] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35955:
URL: https://github.com/apache/spark/pull/35955#discussion_r833869932
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1713,6 +1713,25 @@ spec:
image: will-be-overwritten
```
+#### Customized Kubernetes Schedulers for Spark on Kubernetes
+
+Spark allows users to specify a custom Kubernetes schedulers.
Review comment:
`a custom Kubernetes schedulers` -> `custom Kubernetes schedulers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35955: [SPARK-38561][K8S][DOCS][3.3] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35955:
URL: https://github.com/apache/spark/pull/35955#discussion_r833871962
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1713,6 +1713,25 @@ spec:
image: will-be-overwritten
```
+#### Customized Kubernetes Schedulers for Spark on Kubernetes
+
+Spark allows users to specify a custom Kubernetes schedulers.
+
+1. Specify scheduler name.
+
+ Users can specify a custom scheduler using <code>spark.kubernetes.scheduler.name</code> or
+ <code>spark.kubernetes.{driver/executor}.scheduler.name</code> configuration.
+
+2. Specify scheduler related configurations.
+
+ To configure the custom scheduler the user can use [Pod templates](#pod-template), add labels (<code>spark.kubernetes.{driver,executor}.label.*</code>) and/or annotations (<code>spark.kubernetes.{driver/executor}.annotation.*</code>).
+
+3. Specify scheduler feature step.
+
+ Users may also consider to use <code>spark.kubernetes.{driver/executor}.pod.featureSteps</code> to support more complex requirements, including but not limited to:
+ - Create additional Kubernetes custom resources for driver/executor scheduling.
+ - Set scheduler hints according to configuration or existing Pod info dynamically.
Review comment:
What does this refer in Volcano scheduler?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #35955: [SPARK-38561][K8S][DOCS][3.3] Add doc for `Customized Kubernetes Schedulers`
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #35955:
URL: https://github.com/apache/spark/pull/35955#discussion_r833871007
##########
File path: docs/running-on-kubernetes.md
##########
@@ -1713,6 +1713,25 @@ spec:
image: will-be-overwritten
```
+#### Customized Kubernetes Schedulers for Spark on Kubernetes
+
+Spark allows users to specify a custom Kubernetes schedulers.
+
+1. Specify scheduler name.
+
+ Users can specify a custom scheduler using <code>spark.kubernetes.scheduler.name</code> or
+ <code>spark.kubernetes.{driver/executor}.scheduler.name</code> configuration.
+
+2. Specify scheduler related configurations.
+
+ To configure the custom scheduler the user can use [Pod templates](#pod-template), add labels (<code>spark.kubernetes.{driver,executor}.label.*</code>) and/or annotations (<code>spark.kubernetes.{driver/executor}.annotation.*</code>).
Review comment:
Hmm. It seems that you missed the most important thing, `PodGroupTemplate`, here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org