You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2022/12/02 18:19:19 UTC
[kudu-CR] Make HasColumn work without specifying col schema
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19315
Change subject: Make HasColumn work without specifying col_schema
......................................................................
Make HasColumn work without specifying col_schema
KuduSchema::HasColumn() determines whether a given column name is
present or not in a given schema. If the column is found, a new
KuduColumnSchema object is created, and it is assigned to the argument
col_schema pointer.
There can be cases, where we are only interested in the boolean return
value, and we don't want to obtain the actual column schema.
This patch enables to pass a nullptr as the col_schema argument, if
we don't want to obtain the column schema.
This came up, while working on another patch [1], where there are two
cases where I need to create column schema objects, although only the
boolean information is needed.
[1] https://gerrit.cloudera.org/#/c/19272/2/
src/kudu/client/scan_token-test.cc
Change-Id: I736f55240157a676841db8428c84ee2d78b1cdcd
---
M src/kudu/client/client-test.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/tools/kudu-admin-test.cc
4 files changed, 8 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/19315/1
--
To view, visit http://gerrit.cloudera.org:8080/19315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I736f55240157a676841db8428c84ee2d78b1cdcd
Gerrit-Change-Number: 19315
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
[kudu-CR] Make HasColumn work without specifying col schema
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19315 )
Change subject: Make HasColumn work without specifying col_schema
......................................................................
Make HasColumn work without specifying col_schema
KuduSchema::HasColumn() determines whether a given column name is
present or not in a given schema. If the column is found, a new
KuduColumnSchema object is created, and it is assigned to the argument
col_schema pointer.
There can be cases, where we are only interested in the boolean return
value, and we don't want to obtain the actual column schema.
This patch enables to pass a nullptr as the col_schema argument, if
we don't want to obtain the column schema.
This came up, while working on another patch [1], where there are two
cases where I need to create column schema objects, although only the
boolean information is needed.
[1] https://gerrit.cloudera.org/#/c/19272/2/
src/kudu/client/scan_token-test.cc
Change-Id: I736f55240157a676841db8428c84ee2d78b1cdcd
Reviewed-on: http://gerrit.cloudera.org:8080/19315
Tested-by: Kudu Jenkins
Reviewed-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/client/client-test.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/tools/kudu-admin-test.cc
4 files changed, 8 insertions(+), 12 deletions(-)
Approvals:
Kudu Jenkins: Verified
Alexey Serbin: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I736f55240157a676841db8428c84ee2d78b1cdcd
Gerrit-Change-Number: 19315
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Make HasColumn work without specifying col schema
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19315
to look at the new patch set (#3).
Change subject: Make HasColumn work without specifying col_schema
......................................................................
Make HasColumn work without specifying col_schema
KuduSchema::HasColumn() determines whether a given column name is
present or not in a given schema. If the column is found, a new
KuduColumnSchema object is created, and it is assigned to the argument
col_schema pointer.
There can be cases, where we are only interested in the boolean return
value, and we don't want to obtain the actual column schema.
This patch enables to pass a nullptr as the col_schema argument, if
we don't want to obtain the column schema.
This came up, while working on another patch [1], where there are two
cases where I need to create column schema objects, although only the
boolean information is needed.
[1] https://gerrit.cloudera.org/#/c/19272/2/
src/kudu/client/scan_token-test.cc
Change-Id: I736f55240157a676841db8428c84ee2d78b1cdcd
---
M src/kudu/client/client-test.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/tools/kudu-admin-test.cc
4 files changed, 8 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/19315/3
--
To view, visit http://gerrit.cloudera.org:8080/19315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I736f55240157a676841db8428c84ee2d78b1cdcd
Gerrit-Change-Number: 19315
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Make HasColumn work without specifying col schema
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19315
to look at the new patch set (#2).
Change subject: Make HasColumn work without specifying col_schema
......................................................................
Make HasColumn work without specifying col_schema
KuduSchema::HasColumn() determines whether a given column name is
present or not in a given schema. If the column is found, a new
KuduColumnSchema object is created, and it is assigned to the argument
col_schema pointer.
There can be cases, where we are only interested in the boolean return
value, and we don't want to obtain the actual column schema.
This patch enables to pass a nullptr as the col_schema argument, if
we don't want to obtain the column schema.
This came up, while working on another patch [1], where there are two
cases where I need to create column schema objects, although only the
boolean information is needed.
[1] https://gerrit.cloudera.org/#/c/19272/2/
src/kudu/client/scan_token-test.cc
Change-Id: I736f55240157a676841db8428c84ee2d78b1cdcd
---
M src/kudu/client/client-test.cc
M src/kudu/client/schema.cc
M src/kudu/client/schema.h
M src/kudu/tools/kudu-admin-test.cc
4 files changed, 8 insertions(+), 12 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/19315/2
--
To view, visit http://gerrit.cloudera.org:8080/19315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I736f55240157a676841db8428c84ee2d78b1cdcd
Gerrit-Change-Number: 19315
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Make HasColumn work without specifying col schema
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19315 )
Change subject: Make HasColumn work without specifying col_schema
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19315
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I736f55240157a676841db8428c84ee2d78b1cdcd
Gerrit-Change-Number: 19315
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Tue, 06 Dec 2022 19:58:53 +0000
Gerrit-HasComments: No