[GitHub] [maven-resolver] michael-o commented on a change in pull request #132: File Locking change proposal

[GitBox <gi...@apache.org>]

michael-o commented on a change in pull request #132:
URL: https://github.com/apache/maven-resolver/pull/132#discussion_r733809277



##########
File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/NamedLockFactorySelector.java
##########
@@ -56,11 +56,11 @@
     ) );
 
     private static final String FACTORY_NAME = System.getProperty(
-        "aether.syncContext.named.factory", LocalReadWriteLockNamedLockFactory.NAME
+        "aether.syncContext.named.factory", FileLockNamedLockFactory.NAME
     );
 
     private static final String NAME_MAPPER_NAME = System.getProperty(
-        "aether.syncContext.named.nameMapper", GAVNameMapper.NAME

Review comment:
       No good! People required that Maven by default runs on no-lock filesystems. This issue has been addressed and this would introduce it again.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org