You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Chia-Ping Tsai (JIRA)" <ji...@apache.org> on 2018/02/21 04:52:00 UTC
[jira] [Comment Edited] (HBASE-20001) cleanIfNoMetaEntry() uses
encoded instead of region name to lookup region
[ https://issues.apache.org/jira/browse/HBASE-20001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16368726#comment-16368726 ]
Chia-Ping Tsai edited comment on HBASE-20001 at 2/21/18 4:51 AM:
-----------------------------------------------------------------
-Could we use MetaTableAccessor#etRegionLocation instead? The passed region name is converted to HRegionInfo if we use MetaTableAccessor#getRegion. That is a litter ugly I'd say.-
Seems MetaTableAccessor#etRegionLocation won't return null even if no entry is in .meta.
was (Author: chia7712):
Could we use MetaTableAccessor#etRegionLocation instead? The passed region name is converted to HRegionInfo if we use MetaTableAccessor#getRegion. That is a litter ugly I'd say.
> cleanIfNoMetaEntry() uses encoded instead of region name to lookup region
> -------------------------------------------------------------------------
>
> Key: HBASE-20001
> URL: https://issues.apache.org/jira/browse/HBASE-20001
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.2.0, 1.3.0, 1.4.0, 1.1.7
> Reporter: Francis Liu
> Assignee: Thiruvel Thirumoolan
> Priority: Major
> Fix For: 1.3.2, 1.5.0, 1.2.7, 1.4.3
>
> Attachments: HBASE-20001.branch-1.4.001.patch
>
>
> In RegionStates.cleanIfNoMetaEntry()
> {{if (MetaTableAccessor.getRegion(server.getConnection(), hri.getEncodedNameAsBytes()) == null) {}}
> {{regionOffline(hri);}}
> {{FSUtils.deleteRegionDir(server.getConfiguration(), hri);}}
> }
> But api expects regionname
> {{public static Pair<HRegionInfo, ServerName> getRegion(Connection connection, byte [] regionName)}}
> So we might end up cleaning good regions.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)