You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@age.apache.org by "MironAtHome (via GitHub)" <gi...@apache.org> on 2024/08/09 23:14:12 UTC
[PR] Mironathome issue 2027 fix [age]
MironAtHome opened a new pull request, #2037:
URL: https://github.com/apache/age/pull/2037
Fix issue #2027
get_graph_oid function declaration return type uint32 definition Oid
Make both return Oid
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Mironathome issue 2027 fix [age]
Posted by "MironAtHome (via GitHub)" <gi...@apache.org>.
MironAtHome closed pull request #2037: Mironathome issue 2027 fix
URL: https://github.com/apache/age/pull/2037
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Mironathome issue 2027 fix [age]
Posted by "MironAtHome (via GitHub)" <gi...@apache.org>.
MironAtHome commented on PR #2037:
URL: https://github.com/apache/age/pull/2037#issuecomment-2285025303
> @MironAtHome Have you verified that everywhere it is used uses Oid and not uint32? Additionally, if they do use uint32 why? (it could be a mistake from the migration away from Oids, btw)
I did more than one time.
Everywhere function call is performed, it is returning to variable declared as Oid.
This is intuitive for the most cases, since variable, to which the function returns, is declared as graph_oid for all cases, save for one, where it is named just "graph" and the type of the variable declared is Oid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Mironathome issue 2027 fix [age]
Posted by "MironAtHome (via GitHub)" <gi...@apache.org>.
MironAtHome commented on PR #2037:
URL: https://github.com/apache/age/pull/2037#issuecomment-2285030514
> (it could be a mistake from the migration away from Oids, btw)
Any additional guidance would be appreciated.
If the actual plan is to migrate away from Oid type, I will create one more PR with unsigned int of 32 bit size (uint32).
In this, provided PR, the goal was to ensure that function declaration matches function definition and usage.
Plus get_graph_oid function name seems to carry reference to type oid.
If return type and usage in this planned PR to change away frm Oid, I would propose renaming function to get_graph_id, with new moniker "id" suggesting type independent treatment of graph numerical identifier used by graph database catalogue internally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Mironathome issue 2027 fix [age]
Posted by "jrgemignani (via GitHub)" <gi...@apache.org>.
jrgemignani commented on PR #2037:
URL: https://github.com/apache/age/pull/2037#issuecomment-2278873130
@MironAtHome Have you verified that everywhere it is used uses Oid and not uint32? Additionally, if they do use uint32 why? (it could be a mistake from the migration away from Oids, btw)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@age.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org