You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by ErnieAllen <gi...@git.apache.org> on 2018/10/10 11:21:41 UTC
[GitHub] qpid-dispatch pull request #389: DISPATCH-1130 Expose link priority
GitHub user ErnieAllen opened a pull request:
https://github.com/apache/qpid-dispatch/pull/389
DISPATCH-1130 Expose link priority
Adds priority to router.link management entity in the schema.
Connects link.priority to schema attribute.
Adds priority column to qdstat -l
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ErnieAllen/qpid-dispatch ernie-DISPATCH-1130
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/qpid-dispatch/pull/389.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #389
----
commit a81784b9bcb98c9c46795bff8055ccb73b5fc4d1
Author: Ernest Allen <ea...@...>
Date: 2018-10-10T11:16:00Z
DISPATCH-1130 Expose link priority
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #389: DISPATCH-1130 Expose link priority
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/qpid-dispatch/pull/389
# [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/389?src=pr&el=h1) Report
> Merging [#389](https://codecov.io/gh/apache/qpid-dispatch/pull/389?src=pr&el=desc) into [master](https://codecov.io/gh/apache/qpid-dispatch/commit/d1d6e92df2d3adbba5d86e650e0d44a0ffc0b33e?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/qpid-dispatch/pull/389?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #389 +/- ##
==========================================
- Coverage 85.06% 85.02% -0.04%
==========================================
Files 73 73
Lines 16523 16525 +2
==========================================
- Hits 14055 14051 -4
- Misses 2468 2474 +6
```
| [Impacted Files](https://codecov.io/gh/apache/qpid-dispatch/pull/389?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [src/router\_core/agent\_link.c](https://codecov.io/gh/apache/qpid-dispatch/pull/389/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2FnZW50X2xpbmsuYw==) | `63.63% <100%> (+0.41%)` | :arrow_up: |
| [src/router\_core/core\_timer.c](https://codecov.io/gh/apache/qpid-dispatch/pull/389/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL2NvcmVfdGltZXIuYw==) | `94.64% <0%> (-1.79%)` | :arrow_down: |
| [src/router\_core/modules/core\_test\_hooks.c](https://codecov.io/gh/apache/qpid-dispatch/pull/389/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL21vZHVsZXMvY29yZV90ZXN0X2hvb2tzLmM=) | `89.54% <0%> (-1.37%)` | :arrow_down: |
| [src/router\_core/router\_core.c](https://codecov.io/gh/apache/qpid-dispatch/pull/389/diff?src=pr&el=tree#diff-c3JjL3JvdXRlcl9jb3JlL3JvdXRlcl9jb3JlLmM=) | `92.05% <0%> (-0.34%)` | :arrow_down: |
| [src/container.c](https://codecov.io/gh/apache/qpid-dispatch/pull/389/diff?src=pr&el=tree#diff-c3JjL2NvbnRhaW5lci5j) | `76.55% <0%> (-0.2%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/389?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/qpid-dispatch/pull/389?src=pr&el=footer). Last update [d1d6e92...a81784b](https://codecov.io/gh/apache/qpid-dispatch/pull/389?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch issue #389: DISPATCH-1130 Expose link priority
Posted by ganeshmurthy <gi...@git.apache.org>.
Github user ganeshmurthy commented on the issue:
https://github.com/apache/qpid-dispatch/pull/389
@ErnieAllen This change looks good. As part of this PR, can you also please add a test to system_tests_qdstat to verify that the correct link priority is showing up? Thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[GitHub] qpid-dispatch pull request #389: DISPATCH-1130 Expose link priority
Posted by ErnieAllen <gi...@git.apache.org>.
Github user ErnieAllen closed the pull request at:
https://github.com/apache/qpid-dispatch/pull/389
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org