You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Amar Kamat (JIRA)" <ji...@apache.org> on 2008/07/11 08:23:31 UTC
[jira] Created: (HADOOP-3749) Factor out commonly used code in
mapred testcases
Factor out commonly used code in mapred testcases
-------------------------------------------------
Key: HADOOP-3749
URL: https://issues.apache.org/jira/browse/HADOOP-3749
Project: Hadoop Core
Issue Type: Improvement
Components: test
Reporter: Amar Kamat
Priority: Minor
The commonly used code in the testcases are made _static_ like {{TestRackAwareTaskPlacement.configureJobConf()}}. It would be nice to factor out these apis and either add it to a class like {{StringUtils}} or into a separate dir like {{utils}}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3749) Factor out commonly used code in
mapred testcases
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613428#action_12613428 ]
Doug Cutting commented on HADOOP-3749:
--------------------------------------
I can't find the method you mention in TestRackAwareTaskPlacement, but if the code is only common in tests then it should be factored to the test tree, no?
> Factor out commonly used code in mapred testcases
> -------------------------------------------------
>
> Key: HADOOP-3749
> URL: https://issues.apache.org/jira/browse/HADOOP-3749
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Amar Kamat
> Priority: Minor
>
> The commonly used code in the testcases are made _static_ like {{TestRackAwareTaskPlacement.configureJobConf()}}. It would be nice to factor out these apis and either add it to a class like {{StringUtils}} or into a separate dir like {{utils}}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-3749) Factor out commonly used code in
mapred testcases
Posted by "Amar Kamat (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-3749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12613525#action_12613525 ]
Amar Kamat commented on HADOOP-3749:
------------------------------------
bq. I can't find the method you mention in TestRackAwareTaskPlacement
Oops .. That was from the modified code. What I meant was {{TestRackAwareTaskPlacement.launchJob()}}.
bq. but if the code is only common in tests then it should be factored to the test tree, no?
By {{StringUtils}}/{{utils}}, I meant under test dir.
Sorry for the confusion.
> Factor out commonly used code in mapred testcases
> -------------------------------------------------
>
> Key: HADOOP-3749
> URL: https://issues.apache.org/jira/browse/HADOOP-3749
> Project: Hadoop Core
> Issue Type: Improvement
> Components: test
> Reporter: Amar Kamat
> Priority: Minor
>
> The commonly used code in the testcases are made _static_ like {{TestRackAwareTaskPlacement.configureJobConf()}}. It would be nice to factor out these apis and either add it to a class like {{StringUtils}} or into a separate dir like {{utils}}.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.