You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by "SbloodyS (via GitHub)" <gi...@apache.org> on 2024/07/16 03:20:10 UTC

[PR] [Feature-3862] Add Flink On Yarn Clusters e2e test [incubator-streampark]

SbloodyS opened a new pull request, #3868:
URL: https://github.com/apache/incubator-streampark/pull/3868

   <!--
   Thank you for contributing to StreamPark! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   ## Contribution Checklist
   
     - If this is your first time, please read our contributor guidelines: [Submit Code](https://streampark.apache.org/community/submit_guide/submit_code).
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-streampark/issues).
   
     - Name the pull request in the form "[Feature] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
   
     - If the PR is unfinished, add `[WIP]` in your PR title, e.g., `[WIP][Feature] Title of the pull request`.
   
   -->
   
   ## What changes were proposed in this pull request
   
   Issue Number: close #3862
   
   <!--(For example: This pull request proposed to add checkstyle plugin).-->
   
   ## Brief change log
   
   - Add Flink On Yarn Clusters e2e test
   - Optimize some e2e code
   - Fix add cluster ui bug
   
   ## Verifying this change
   
   <!--*(Please pick either of the following options)*-->
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   <!--*(example:)*
   - *Added integration tests for end-to-end.*
   - *Added *Test to verify the change.*
   - *Manually verified the change by testing locally.* -->
   
   ## Does this pull request potentially affect one of the following parts
    - Dependencies (does it add or upgrade a dependency): (yes / no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature-3862] Add Flink On Yarn Clusters e2e test [incubator-streampark]

Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on code in PR #3868:
URL: https://github.com/apache/incubator-streampark/pull/3868#discussion_r1678731701


##########
.github/workflows/e2e.yml:
##########
@@ -126,6 +126,12 @@ jobs:
             class: org.apache.streampark.e2e.cases.TeamManagementTest
           - name: MemberManagementTest
             class: org.apache.streampark.e2e.cases.MemberManagementTest
+          - name: Flink116OnYarnClustersTest
+            class: org.apache.streampark.e2e.cases.Flink116OnYarnClustersTest

Review Comment:
   Flink supports multiple clusters: yarn-session, standalone, and k8s-session. However, only yarn-session is currently implemented. Is the name of this test case ambiguous?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature-3862] Add Flink On Yarn Clusters e2e test [incubator-streampark]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #3868:
URL: https://github.com/apache/incubator-streampark/pull/3868#discussion_r1678738809


##########
.github/workflows/e2e.yml:
##########
@@ -126,6 +126,12 @@ jobs:
             class: org.apache.streampark.e2e.cases.TeamManagementTest
           - name: MemberManagementTest
             class: org.apache.streampark.e2e.cases.MemberManagementTest
+          - name: Flink116OnYarnClustersTest
+            class: org.apache.streampark.e2e.cases.Flink116OnYarnClustersTest

Review Comment:
   Okay. I'll fix it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature-3862] Add Flink On Yarn Clusters e2e test [incubator-streampark]

Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys commented on code in PR #3868:
URL: https://github.com/apache/incubator-streampark/pull/3868#discussion_r1678735947


##########
.github/workflows/e2e.yml:
##########
@@ -126,6 +126,12 @@ jobs:
             class: org.apache.streampark.e2e.cases.TeamManagementTest
           - name: MemberManagementTest
             class: org.apache.streampark.e2e.cases.MemberManagementTest
+          - name: Flink116OnYarnClustersTest
+            class: org.apache.streampark.e2e.cases.Flink116OnYarnClustersTest

Review Comment:
   This PR provides test cases for deploy and shutdown yarn-session cluster, How about Flink116OnYarnClusterDeployTest ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature-3862] Add Flink On Yarn Clusters e2e test [incubator-streampark]

Posted by "wolfboys (via GitHub)" <gi...@apache.org>.
wolfboys merged PR #3868:
URL: https://github.com/apache/incubator-streampark/pull/3868


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [Feature-3862] Add Flink On Yarn Clusters e2e test [incubator-streampark]

Posted by "SbloodyS (via GitHub)" <gi...@apache.org>.
SbloodyS commented on code in PR #3868:
URL: https://github.com/apache/incubator-streampark/pull/3868#discussion_r1678732614


##########
.github/workflows/e2e.yml:
##########
@@ -126,6 +126,12 @@ jobs:
             class: org.apache.streampark.e2e.cases.TeamManagementTest
           - name: MemberManagementTest
             class: org.apache.streampark.e2e.cases.MemberManagementTest
+          - name: Flink116OnYarnClustersTest
+            class: org.apache.streampark.e2e.cases.Flink116OnYarnClustersTest

Review Comment:
   Maybe using `Flink116OnYarnSessionClustersTest`? Do you have better idea?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org