[GitHub] [incubator-pinot] mcvsubbu commented on pull request #5700: [Deepstore by-passing]Introduce a subclasses SplitSegmentCommitter which will proceeds to commit even if the segment upload fails.

[GitBox <gi...@apache.org>]

mcvsubbu commented on pull request #5700:
URL: https://github.com/apache/incubator-pinot/pull/5700#issuecomment-663165120


   @chenboat  please add some tests in another follow-up commit. Here is what I would suggest:
   1. You can start a thread that behaves like deepstore, failing the commit. Start another thread, that starts only the committer, mocking everything else. Start a server fake server thread that in externalview seem online for the segment. Assert that the server gets a request for download, and assert the segment commit passes. This verifies only the server side.
   2. Controller verificaton can be done independently, I think. All that we need to verify is that when a segment is committed with "PEER" in the URI, the metadata for segment URI is null. You can probably do this by starting a controller, mocking a realtime segment, and posting a consumed followed by commit call using http.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org