[GitHub] [incubator-doris] chenhao7253886 commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result

[GitBox <gi...@apache.org>]

chenhao7253886 commented on a change in pull request #1516: Fix bug that <=> operator and in operator get wrong result
URL: https://github.com/apache/incubator-doris/pull/1516#discussion_r305608601
 
 

 ##########
 File path: be/src/exprs/binary_predicate.h
 ##########
 @@ -41,8 +41,28 @@ class BinaryPredicate : public Predicate {
     // virtual Status prepare(RuntimeState* state, const RowDescriptor& desc);
     virtual std::string debug_string() const;
 
+   
     Status codegen_compare_fn(
         RuntimeState* state, llvm::Function** fn, llvm::CmpInst::Predicate pred);
+
+    bool get_result_for_null(const AnyVal& v1, const AnyVal& v2, BooleanVal* result) {
 
 Review comment:
   ok.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org