[GitHub] [inlong] healchow commented on a diff in pull request #5202: [INLONG-5201][Manager] Find entities in the database before updating inlong group

[GitBox <gi...@apache.org>]

healchow commented on code in PR #5202:
URL: https://github.com/apache/inlong/pull/5202#discussion_r928984471


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/workflow/group/listener/apply/AfterApprovedTaskListener.java:
##########
@@ -74,7 +74,7 @@ public ListenerResult listen(WorkflowContext context) throws WorkflowListenerExc
         }
 
         // save the inlong group and other info after approval
-        groupService.updateAfterApprove(approveInfo, context.getOperator());
+        groupService.updateAfterApprove(approveInfo, context.getOperator(), entity);

Review Comment:
   Suggest moving the check and entity into the `updateAfterApprove ` method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org