You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/11/23 01:05:00 UTC
[jira] [Commented] (METRON-1313) Update metron-deployment to use
bro-pkg to install the kafka plugin
[ https://issues.apache.org/jira/browse/METRON-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263639#comment-16263639 ]
ASF GitHub Bot commented on METRON-1313:
----------------------------------------
GitHub user JonZeolla opened a pull request:
https://github.com/apache/metron/pull/847
METRON-1313: Update metron-deployment to use bro-pkg to install the kafka plugin
## Contributor Comments
This PR requires #844.
For testing, this PR currently references my fork of metron-bro-plugin-kafka, as it is leveraging a [git tag](http://bro-package-manager.readthedocs.io/en/stable/package.html?highlight=tag#package-versioning) that I didn't want to push without a review. The merge of this will need to be coordinated with apache/metron-bro-plugin-kafka#4, and a corollary 0.1 tag against HEAD.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.
Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [X] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [X] Has your PR been rebased against the latest commit within the target branch (typically master)?
### For code changes:
- [X] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
- [X] Have you included steps or a guide to how the change may be verified and tested manually?
- [X] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
```
mvn -q clean integration-test install && build_utils/verify_licenses.sh
```
- [X] Have you written or updated unit tests and or integration tests to verify your changes?
- [X] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [X] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/JonZeolla/metron METRON-1313
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/847.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #847
----
----
> Update metron-deployment to use bro-pkg to install the kafka plugin
> -------------------------------------------------------------------
>
> Key: METRON-1313
> URL: https://issues.apache.org/jira/browse/METRON-1313
> Project: Metron
> Issue Type: Improvement
> Reporter: Jon Zeolla
> Assignee: Jon Zeolla
>
> Update metron-deployment to use bro-pkg to install apache/metron-bro-plugin-kafka.
> This requires that the remote repo is a valid bro package and has been registered in github.com/bro/packages
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)