You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by dongeforever <gi...@git.apache.org> on 2017/04/21 10:01:50 UTC
[GitHub] incubator-rocketmq pull request #96: [ROCKETMQ-187]Measure the code coverage...
GitHub user dongeforever opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/96
[ROCKETMQ-187]Measure the code coverage for Integration Tests, and add sonar-apache profile
https://issues.apache.org/jira/browse/ROCKETMQ-187
Now we could browse the Unit Tests and IT Tests at
https://builds.apache.org/analysis/component_measures/?id=org.apache.rocketmq%3Arocketmq-all
But the IT Test coverage is not correct. It should cover the original sources instead of the the classes in test module.
As for as I known, the coverage report is generated by matching the collected data(often using java agent) against a set of classes (the module classes compiled from src/main/). you could refer to: http://olafsblog.sysbsb.de/measuring-test-coverage-of-integration-tests-for-separated-modules-with-jacoco/
So we could match the jacoco-it.exec to each module's source classes to get the correct IT coverage report.
By the way, we'd better exclude the classes in the test module.
we may use sonar locally.
So we'd better use profile to handle different occasions
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dongeforever/incubator-rocketmq IT_POLISH
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/96.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #96
----
commit d7a155a4e8d66f20ff4ca4dca55368b593185e9c
Author: dongeforever <zh...@yeah.net>
Date: 2017-04-18T12:42:29Z
Revise IT code coverage, add sonar-apache profile
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq pull request #96: [ROCKETMQ-187]Measure the code coverage...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever closed the pull request at:
https://github.com/apache/incubator-rocketmq/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...
Posted by lizhanhui <gi...@git.apache.org>.
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/96
It's good and looks it's already been merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/96
The PR is better not to be merged by the original author.
@lizhanhui @zhouxinyu @shroman please help merge this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...
Posted by dongeforever <gi...@git.apache.org>.
Github user dongeforever commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/96
@lizhanhui @zhouxinyu @vongosling please have a review
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...
Posted by vongosling <gi...@git.apache.org>.
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/96
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-rocketmq issue #96: [ROCKETMQ-187]Measure the code coverage for In...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/96
[](https://coveralls.io/builds/11179609)
Coverage increased (+0.06%) to 34.694% when pulling **d7a155a4e8d66f20ff4ca4dca55368b593185e9c on dongeforever:IT_POLISH** into **42f78c281cbeb5072b04eaf03b1a8059b8d281a7 on apache:develop**.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---