[jira] [Commented] (THRIFT-4284) File contains a NBSP: lib/nodejs/lib/thrift/web_server.js

["Jens Geyer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16123426#comment-16123426 ] 

Jens Geyer commented on THRIFT-4284:
------------------------------------

Hi, thanks for catching this. 

If you are able to provide a pull request, someone will take care of it.

http://thrift.apache.org/docs/HowToContribute



> File contains a NBSP: lib/nodejs/lib/thrift/web_server.js
> ---------------------------------------------------------
>
>                 Key: THRIFT-4284
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4284
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Library
>    Affects Versions: 0.9.2, 0.9.3, 0.10.0
>            Reporter: Claudio Procida
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> This file contains a non-breaking space ({{\u00a0}}): {{lib/nodejs/lib/thrift/web_server.js}}
> We found the issue while bundling the npm module [thrift|https://npm.im] with {{browserify}}, resulting into a syntax error in the browser.
> If you look at line 287 in [the raw file|https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob_plain;f=lib/nodejs/lib/thrift/web_server.js;hb=HEAD], there is an {{'Â'}} character between a value and the next key. Interestingly, the [web UI|https://git-wip-us.apache.org/repos/asf?p=thrift.git;a=blob;f=lib/nodejs/lib/thrift/web_server.js;hb=HEAD#l287] doesn't show the issue.
> The [raw file on the GitHub mirror|https://raw.githubusercontent.com/apache/thrift/master/lib/nodejs/lib/thrift/web_server.js] is not garbled.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)