[GitHub] ddavydenko opened a new pull request #11444: Fix flaky test test_operator_gpu.test_spatial_transformer_with_type (…

[GitBox <gi...@apache.org>]

ddavydenko opened a new pull request #11444: Fix flaky test test_operator_gpu.test_spatial_transformer_with_type (…
URL: https://github.com/apache/incubator-mxnet/pull/11444
 
 
   …#7645)
   
   ## Description ##
   Modified test_operator_gpu.test_spatial_transformer_with_type test in order to remove its flakiness
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [X] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [X] removed predefined seed from the test
   - [X] updated precision of comparison object from float32 to float64
   
   ## Comments ##
   I confirmed that original test code was causing test to consistently fail even with 100 iterations of running it with the error specified in original [issue](https://github.com/apache/incubator-mxnet/issues/7645). After code modification I tested on 100,000 iterations and didn't notice single test failure.
   `PYTHONPATH=./python/ MXNET_TEST_COUNT=100000 nosetests —verbose tests/python/gpu/test_operator_gpu.py:test_spatial_transformer_with_type` was used to run the test.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services