You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andriy Babiichuk <ab...@hortonworks.com> on 2014/10/15 19:39:29 UTC

Review Request 26759: On add service, the Cap scheduler is being expanded into individual props

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26759/
-----------------------------------------------------------

Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.


Bugs: AMBARI-7793
    https://issues.apache.org/jira/browse/AMBARI-7793


Repository: ambari


Description
-------

1. Go to add service
2. An Customize Configs, all the capacity scheduler configs are expanded in name=value properties, in addition to showing the "Scheduler" content area. They should not have been expanded.


Diffs
-----

  ambari-web/app/controllers/wizard/step7_controller.js c00d743 
  ambari-web/test/controllers/wizard/step7_test.js ce07144 

Diff: https://reviews.apache.org/r/26759/diff/


Testing
-------

4 tests added  
4485 tests complete (5 seconds)
60 tests pending


Thanks,

Andriy Babiichuk


Re: Review Request 26759: On add service, the Cap scheduler is being expanded into individual props

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26759/#review56743
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On Жов. 15, 2014, 5:39 після полудня, Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26759/
> -----------------------------------------------------------
> 
> (Updated Жов. 15, 2014, 5:39 після полудня)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-7793
>     https://issues.apache.org/jira/browse/AMBARI-7793
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. Go to add service
> 2. An Customize Configs, all the capacity scheduler configs are expanded in name=value properties, in addition to showing the "Scheduler" content area. They should not have been expanded.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step7_controller.js c00d743 
>   ambari-web/test/controllers/wizard/step7_test.js ce07144 
> 
> Diff: https://reviews.apache.org/r/26759/diff/
> 
> 
> Testing
> -------
> 
> 4 tests added  
> 4485 tests complete (5 seconds)
> 60 tests pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>


Re: Review Request 26759: On add service, the Cap scheduler is being expanded into individual props

Posted by Oleg Nechiporenko <on...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26759/#review56744
-----------------------------------------------------------

Ship it!


Ship It!

- Oleg Nechiporenko


On Oct. 15, 2014, 5:39 p.m., Andriy Babiichuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26759/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 5:39 p.m.)
> 
> 
> Review request for Ambari, Aleksandr Kovalenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-7793
>     https://issues.apache.org/jira/browse/AMBARI-7793
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. Go to add service
> 2. An Customize Configs, all the capacity scheduler configs are expanded in name=value properties, in addition to showing the "Scheduler" content area. They should not have been expanded.
> 
> 
> Diffs
> -----
> 
>   ambari-web/app/controllers/wizard/step7_controller.js c00d743 
>   ambari-web/test/controllers/wizard/step7_test.js ce07144 
> 
> Diff: https://reviews.apache.org/r/26759/diff/
> 
> 
> Testing
> -------
> 
> 4 tests added  
> 4485 tests complete (5 seconds)
> 60 tests pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>