You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/07/09 08:13:56 UTC
[GitHub] [shardingsphere] strongduanmu opened a new pull request, #18975: Use byte stream to load config file when use ShardingSphere Driver with SpringBoot fatjar
strongduanmu opened a new pull request, #18975:
URL: https://github.com/apache/shardingsphere/pull/18975
Fixes #18968.
Changes proposed in this pull request:
- use byte stream to load config file when use ShardingSphere Driver with SpringBoot fatjar
- update unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #18975: Use byte stream to load config file when use ShardingSphere Driver with SpringBoot fatjar
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18975:
URL: https://github.com/apache/shardingsphere/pull/18975#issuecomment-1179507579
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18975?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#18975](https://codecov.io/gh/apache/shardingsphere/pull/18975?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1776a03) into [master](https://codecov.io/gh/apache/shardingsphere/commit/210071f5bdf639774e4fa47a0f4824f81acbd530?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (210071f) will **decrease** coverage by `0.00%`.
> The diff coverage is `57.14%`.
```diff
@@ Coverage Diff @@
## master #18975 +/- ##
============================================
- Coverage 59.38% 59.38% -0.01%
Complexity 2316 2316
============================================
Files 3799 3799
Lines 54692 54696 +4
Branches 9240 9242 +2
============================================
+ Hits 32480 32481 +1
- Misses 19481 19482 +1
- Partials 2731 2733 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18975?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...iver/jdbc/core/driver/ShardingSphereDriverURL.java](https://codecov.io/gh/apache/shardingsphere/pull/18975/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvZHJpdmVyL1NoYXJkaW5nU3BoZXJlRHJpdmVyVVJMLmphdmE=) | `80.00% <50.00%> (-20.00%)` | :arrow_down: |
| [...driver/jdbc/core/driver/DriverDataSourceCache.java](https://codecov.io/gh/apache/shardingsphere/pull/18975/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvZHJpdmVyL0RyaXZlckRhdGFTb3VyY2VDYWNoZS5qYXZh) | `50.00% <100.00%> (ø)` | |
| [.../api/yaml/YamlShardingSphereDataSourceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/18975/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9hcGkveWFtbC9ZYW1sU2hhcmRpbmdTcGhlcmVEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `62.50% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18975?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18975?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [210071f...1776a03](https://codecov.io/gh/apache/shardingsphere/pull/18975?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #18975: Use byte stream to load config file when use ShardingSphere Driver with SpringBoot fatjar
Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #18975:
URL: https://github.com/apache/shardingsphere/pull/18975
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org