You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Appy (JIRA)" <ji...@apache.org> on 2018/01/02 22:47:00 UTC

[jira] [Commented] (HBASE-19613) Review of WALSplitter Class

    [ https://issues.apache.org/jira/browse/HBASE-19613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308831#comment-16308831 ] 

Appy commented on HBASE-19613:
------------------------------

lgtm +1
Conversion of entryBuffer from LinkedList to ArrayList looks good given how it is used - iterator, add(), size().

> Review of WALSplitter Class
> ---------------------------
>
>                 Key: HBASE-19613
>                 URL: https://issues.apache.org/jira/browse/HBASE-19613
>             Project: HBase
>          Issue Type: Improvement
>          Components: hbase
>    Affects Versions: 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Trivial
>         Attachments: HBASE-19613.1.patch
>
>
> * Use ArrayList instead LinkedList
> * Use Apache Commons where appropriate
> * Parameterize and improve logging



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)