You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bb...@apache.org on 2018/11/07 22:29:43 UTC
[mesos] 05/08: Fixed flakiness in
`PartitionTest.TaskCompletedOnPartitionedAgent`.
This is an automated email from the ASF dual-hosted git repository.
bbannier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/mesos.git
commit 82844698d8845474314c4609d7bbe477cc1f33f9
Author: Benjamin Mahler <bm...@apache.org>
AuthorDate: Wed Nov 7 22:46:43 2018 +0100
Fixed flakiness in `PartitionTest.TaskCompletedOnPartitionedAgent`.
The test wasn't ensuring that the TASK_FINISHED update gets
processed by the agent before it re-registers with the master, so
sometimes the master will forward the old TASK_RUNNING state.
Review: https://reviews.apache.org/r/69280/
---
src/tests/partition_tests.cpp | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/tests/partition_tests.cpp b/src/tests/partition_tests.cpp
index 788d3b9..15af47b 100644
--- a/src/tests/partition_tests.cpp
+++ b/src/tests/partition_tests.cpp
@@ -2380,6 +2380,9 @@ TEST_F(PartitionTest, TaskCompletedOnPartitionedAgent)
execDriver->sendStatusUpdate(finishedStatus);
}
+ // Ensure the agent processes the task finished update.
+ Clock::settle();
+
// Cause the slave to reregister with the master. Because the
// framework is not partition-aware, this results in shutting down
// the executor on the slave. The enqueued TASK_FINISHED update