You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hop.apache.org by GitBox <gi...@apache.org> on 2020/11/23 04:00:49 UTC
[GitHub] [incubator-hop] HiromuHota opened a new pull request #405: Use SWT.PUSH instead of SWT.CASCADE for a menuitem w/o a submenu
HiromuHota opened a new pull request #405:
URL: https://github.com/apache/incubator-hop/pull/405
As reported [here](https://bugs.eclipse.org/bugs/show_bug.cgi?id=569046), a menuitem with `SWT.CASCADE` w/o a submenu is NOT clickable on RAP/RWT.
For the purpose of single-sourcing, please change them to `SWT.PUSH`.
This is 0.40-20201024.141657-74:
<img width="742" alt="0 40" src="https://user-images.githubusercontent.com/20668349/99928048-5c7cde00-2cfc-11eb-9ee7-1138487527c2.png">
As can been seen, these menuitems do not have a submenu; hence they can simply be `SWT.PUSH`.
This is the patched one:
<img width="525" alt="Screen Shot 2020-11-22 at 19 59 01" src="https://user-images.githubusercontent.com/20668349/99928273-3a379000-2cfd-11eb-8359-13471d7c6ab2.png">
They look and work same as before.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva merged pull request #405: Use SWT.PUSH instead of SWT.CASCADE for a menuitem w/o a submenu
Posted by GitBox <gi...@apache.org>.
hansva merged pull request #405:
URL: https://github.com/apache/incubator-hop/pull/405
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-hop] hansva commented on pull request #405: Use SWT.PUSH instead of SWT.CASCADE for a menuitem w/o a submenu
Posted by GitBox <gi...@apache.org>.
hansva commented on pull request #405:
URL: https://github.com/apache/incubator-hop/pull/405#issuecomment-732001920
Updated https://hop.apache.org/dev-manual/latest/webhop/developer-guide.html to include this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org