[jira] [Commented] (DIRAPI-216) Improvements in OSGi tests

["Emmanuel Lecharny (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DIRAPI-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291775#comment-14291775 ] 

Emmanuel Lecharny commented on DIRAPI-216:
------------------------------------------

Moving everything to a module is possible, but not easy... I tried, but OSGi is no helping me :/ Here is what I get :

{code}
-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running org.apache.directory.api.osgi.ApiAsn1ApiOsgiTest

11:20:12.173 [BundleWatcher: 1] ERROR o.o.p.s.extender.BundleWatcher - Exception in executor thread
java.lang.NoClassDefFoundError: org/apache/directory/api/test/osgi/AbstractOsgiTest
	at java.lang.ClassLoader.defineClass1(Native Method) ~[na:1.7.0_55]
	at java.lang.ClassLoader.defineClass(ClassLoader.java:800) ~[na:1.7.0_55]
	at org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.findClass(BundleWiringImpl.java:2318) ~[org.apache.felix.framework-4.4.1.jar:na]
	at org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1524) ~[org.apache.felix.framework-4.4.1.jar:na]
	at org.apache.felix.framework.BundleWiringImpl.access$400(BundleWiringImpl.java:77) ~[org.apache.felix.framework-4.4.1.jar:na]
	at org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:1993) ~[org.apache.felix.framework-4.4.1.jar:na]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:358) ~[na:1.7.0_55]
	at org.apache.felix.framework.Felix.loadBundleClass(Felix.java:1853) ~[org.apache.felix.framework-4.4.1.jar:na]
	at org.apache.felix.framework.BundleImpl.loadClass(BundleImpl.java:958) ~[org.apache.felix.framework-4.4.1.jar:na]
	at org.ops4j.pax.exam.invoker.junit.internal.JUnitProbeInvoker.<init>(JUnitProbeInvoker.java:65) ~[na:na]
	at org.ops4j.pax.exam.invoker.junit.internal.JUnitProbeInvokerFactory.createProbeInvoker(JUnitProbeInvokerFactory.java:36) ~[na:na]
	at org.ops4j.pax.exam.raw.extender.intern.Parser.createInvoker(Parser.java:81) ~[na:na]
	at org.ops4j.pax.exam.raw.extender.intern.Parser.make(Parser.java:68) ~[na:na]
	at org.ops4j.pax.exam.raw.extender.intern.Parser.<init>(Parser.java:54) ~[na:na]
	at org.ops4j.pax.exam.raw.extender.intern.TestBundleObserver.addingEntries(TestBundleObserver.java:69) ~[na:na]
	at org.ops4j.pax.swissbox.extender.BundleWatcher$3.run(BundleWatcher.java:226) ~[na:na]
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) [na:1.7.0_55]
	at java.util.concurrent.FutureTask.run(FutureTask.java:262) [na:1.7.0_55]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:178) [na:1.7.0_55]
	at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:292) [na:1.7.0_55]
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) [na:1.7.0_55]
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) [na:1.7.0_55]
	at java.lang.Thread.run(Thread.java:745) [na:1.7.0_55]
Caused by: java.lang.ClassNotFoundException: org.apache.directory.api.test.osgi.AbstractOsgiTest not found by PAXEXAM-PROBE-3a1262ff-de10-4a6c-9671-2b3453b47b0f [44]
	at org.apache.felix.framework.BundleWiringImpl.findClassOrResourceByDelegation(BundleWiringImpl.java:1556) ~[org.apache.felix.framework-4.4.1.jar:na]
	at org.apache.felix.framework.BundleWiringImpl.access$400(BundleWiringImpl.java:77) ~[org.apache.felix.framework-4.4.1.jar:na]
	at org.apache.felix.framework.BundleWiringImpl$BundleClassLoader.loadClass(BundleWiringImpl.java:1993) ~[org.apache.felix.framework-4.4.1.jar:na]
	at java.lang.ClassLoader.loadClass(ClassLoader.java:358) ~[na:1.7.0_55]
	... 23 common frames omitted
{code}

Will try harder tonite...

> Improvements in OSGi tests
> --------------------------
>
>                 Key: DIRAPI-216
>                 URL: https://issues.apache.org/jira/browse/DIRAPI-216
>             Project: Directory Client API
>          Issue Type: Task
>            Reporter: Stefan Seelmann
>            Priority: Minor
>             Fix For: 1.0.0-M29
>
>
> Follow up for DIRAPI-215 and DIRSERVER-2041.
> api/integ-osgi and server/osgi-integ duplicate some code (pom.xml declarations and ApiOsgiTestBase/ServerOsgiTestBase. It would be nice to extract this code and make it reusable.
> Further possible improvements:
> * Try to move tests to their modules, to allow faster feedback
> * Currently only some classes are used and instantiated to ensure that classes can be loaded. But the coverage is only minimal. it would be nice to run all the tests as pax-exam test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)