You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Peter N. Lundblad" <lu...@softhome.net> on 2004/05/12 20:37:33 UTC
[PATCH] Eliminate some message fragments for I18N
Hi,
Message fragments are evil for translators, so we need to get rid of them.
This patch does this for some that I found. Some were already _()-marked,
others contain revision numbers and aren't marked yet. I do this in
preparation for marking them, but I do it in separate steps, so that it'll
be easier to review. This patch includes small restructurings of code, so
we have to be more careful than with just _()-marking.
Regards,
//Peter
Re: [PATCH] Eliminate some message fragments for I18N
Posted by "Peter N. Lundblad" <lu...@softhome.net>.
On Wed, 12 May 2004, [UTF-8] Branko Ä^Libej wrote:
> Peter N. Lundblad wrote:
>
> >Message fragments are evil for translators, so we need to get rid of them.
> >This patch does this for some that I found. Some were already _()-marked,
> >others contain revision numbers and aren't marked yet. I do this in
> >preparation for marking them, but I do it in separate steps, so that it'll
> >be easier to review. This patch includes small restructurings of code, so
> >we have to be more careful than with just _()-marking.
> >
> These look good to me. +1, assuming tests pass.
>
Thansk, brane. Tests passed, so r9703.
//Peter
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [PATCH] Eliminate some message fragments for I18N
Posted by Branko Čibej <br...@xbc.nu>.
Peter N. Lundblad wrote:
>Hi,
>
>Message fragments are evil for translators, so we need to get rid of them.
>This patch does this for some that I found. Some were already _()-marked,
>others contain revision numbers and aren't marked yet. I do this in
>preparation for marking them, but I do it in separate steps, so that it'll
>be easier to review. This patch includes small restructurings of code, so
>we have to be more careful than with just _()-marking.
>
>Regards,
>//Peter
>
>------------------------------------------------------------------------
>
>Removed string composition in preparation for more _() markers.
>
>* subversion/clients/cmdline/notify.c (notify):
> Remove sentence fragments as arguments in conditionals to printf, factoring
> out the condition into an if statement outside the printf.
>
>* subversion/libsvn_wc/adm_ops.c (revert_error):
> Remove, factoring out it into its callers.
>
>* subversion/libsvn_wc/props.c (validate_prop_against_node_kind):
> Restructure so that each error message is complete.
>
>
These look good to me. +1, assuming tests pass.
-- Brane
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org