[GitHub] helix pull request: [HELIX-592] addCluster should respect overwrit...

[kanakb <gi...@git.apache.org>]

Github user kanakb commented on a diff in the pull request:

    https://github.com/apache/helix/pull/26#discussion_r29550320
  
    --- Diff: helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java ---
    @@ -329,8 +329,9 @@ public HelixAdmin getClusterManagementTool() {
         return _admin;
       }
     
    -  public void addStateModelDef(String clusterName, String stateModelDef, StateModelDefinition record) {
    --- End diff --
    
    Please do not remove public methods. Instead, call the new method from the old one with a default value.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---