You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ra...@apache.org on 2018/09/30 00:45:30 UTC
[cordova-lib] branch cross-spawn-test updated (cd1cc0c -> 460d3ac)
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a change to branch cross-spawn-test
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git.
discard cd1cc0c TEMP revert to default jasmine reporter
discard 19622de CB-14166: (cli) Fixed issue when install plugins on windows
add 21cf61b Add unit tests for `Context#requireCordovaModule`
add 1fdc38d Fix for module names that start with "cordova-lib"
add 27a2cfd Emit deprecation warning when requiring non-cordova modules
add 74ffd92 Update JSDoc and clarify inline comments
add 81439dc Merge pull request #707 from raphinesse/deprecate-requireCordovaModule
add 58aa9f7 CB-7078 Rewrite disabled test for serve as unit test
add 17938d8 Fix globby usage in cordova/serve
add a8f04e5 Add failing test resulting in pending promise
add 3ed7530 Correctly reject promise when failing
add 1ae1562 Use `md5-file` to calculate MD5 sum of files
add 5a178d1 Refactor platform serve handler & add tests
add 5bb3849 Simplify absolute path handler
add 26ade93 Render index page from a template
add 7163cd7 Make use of express default 404
add be8fdff Improve testability of main export
add d1becda Improve tests after improving testability
add 9f6fadd Organize imports
add f41b829 Add failing test for handling failed server launch
add 36ce5a5 Fix waiting for launched server
add ba90e39 Merge pull request #687 from raphinesse/to-serve-and-protect
add 9c3ce13 Replace leftover usage of Q's instance API
add ce99066 Search and replace usage of Q's static API
add 86394db Fix linting error `prefer-promise-reject-errors`
add 7681351 Replace `Q.delay` with npm package `delay`
add eb9aa97 Use `superspawn` to get rid of `Q.defer` in plugman/install
add af1a1b5 Rewrite cordova/requirements to get rid of `Q.allSettled`
add 4701dcb Add ESLint rule against unhandled promises
add ddac33d Fix some unhandled promises
add 54a9b3d Remove Q :tada:
add 53b2ebb Merge pull request #710 from raphinesse/q-nomore
new 2820f58 CB-14166: (cli) Fixed issue when install plugins on windows
new 460d3ac TEMP revert to default jasmine reporter
This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version. This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:
* -- * -- B -- O -- O -- O (cd1cc0c)
\
N -- N -- N refs/heads/cross-spawn-test (460d3ac)
You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.
Any revisions marked "omit" are not gone; other references still
refer to them. Any revisions marked "discard" are gone forever.
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.eslintrc.yml | 1 +
integration-tests/HooksRunner.spec.js | 12 +-
integration-tests/pkgJson.spec.js | 2 +-
integration-tests/plugin.spec.js | 5 +-
integration-tests/plugman_fetch.spec.js | 5 +-
integration-tests/plugman_uninstall.spec.js | 9 +-
package.json | 3 +-
spec/cordova/build.spec.js | 9 +-
spec/cordova/compile.spec.js | 7 +-
spec/cordova/emulate.spec.js | 13 +-
spec/cordova/platform/addHelper.spec.js | 23 +-
spec/cordova/platform/check.spec.js | 14 +-
spec/cordova/platform/list.spec.js | 3 +-
spec/cordova/platform/platform.spec.js | 3 +-
spec/cordova/platform/remove.spec.js | 3 +-
spec/cordova/plugin/add.spec.js | 21 +-
spec/cordova/plugin/list.spec.js | 9 +-
spec/cordova/plugin/remove.spec.js | 9 +-
spec/cordova/prepare.spec.js | 17 +-
spec/cordova/run.spec.js | 17 +-
spec/cordova/serve.spec.js | 495 +++++++++++++++-------
spec/helpers.js | 24 ++
spec/hooks/Context.spec.js | 108 +++++
spec/plugman/install.spec.js | 36 +-
src/cordova/build.js | 3 +-
src/cordova/clean.js | 3 +-
src/cordova/compile.js | 3 +-
src/cordova/emulate.js | 7 +-
src/cordova/info.js | 9 +-
src/cordova/platform/addHelper.js | 13 +-
src/cordova/platform/check.js | 4 +-
src/cordova/platform/getPlatformDetailsFromDir.js | 7 +-
src/cordova/platform/index.js | 5 +-
src/cordova/platform/remove.js | 3 +-
src/cordova/plugin/add.js | 17 +-
src/cordova/plugin/index.js | 5 +-
src/cordova/plugin/remove.js | 5 +-
src/cordova/plugin/save.js | 5 +-
src/cordova/prepare.js | 9 +-
src/cordova/project_metadata.js | 5 +-
src/cordova/requirements.js | 35 +-
src/cordova/restore-util.js | 9 +-
src/cordova/run.js | 7 +-
src/cordova/serve.js | 266 ++++++------
src/cordova/targets.js | 3 +-
src/cordova/util.js | 3 +-
src/hooks/Context.js | 35 +-
src/hooks/HooksRunner.js | 21 +-
src/plugman/create.js | 5 +-
src/plugman/createpackagejson.js | 3 +-
src/plugman/fetch.js | 23 +-
src/plugman/install.js | 90 ++--
src/plugman/platform.js | 15 +-
src/plugman/plugman.js | 5 +-
src/plugman/uninstall.js | 27 +-
src/util/promise-util.js | 10 +-
56 files changed, 890 insertions(+), 618 deletions(-)
create mode 100644 spec/hooks/Context.spec.js
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-lib] 01/02: CB-14166: (cli) Fixed issue when install
plugins on windows
Posted by ra...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch cross-spawn-test
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git
commit 2820f583144a16aeef298f375384ef7a9dfb6ef5
Author: Almir Kadric <gi...@almirkadric.com>
AuthorDate: Tue Jul 17 03:23:57 2018 +0900
CB-14166: (cli) Fixed issue when install plugins on windows
The npm package name is already wrapped in quotes to prevent special
characters from being execute. However the additional win32 code was
further injecting quotes around the version causing npm to return a
EINVALIDTAGNAME error. The win32 code is redundant and seems to not
be required.
---
src/plugman/fetch.js | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/src/plugman/fetch.js b/src/plugman/fetch.js
index b5994f9..74b8e76 100644
--- a/src/plugman/fetch.js
+++ b/src/plugman/fetch.js
@@ -119,7 +119,6 @@ function fetchPlugin (plugin_src, plugins_dir, options) {
var parsedSpec = pluginSpec.parse(plugin_src);
var P;
var skipCopyingPlugin;
- var specContainsSpecialCharacters = false;
plugin_dir = path.join(plugins_dir, parsedSpec.id);
// if the plugin has already been fetched, use it.
if (fs.existsSync(plugin_dir)) {
@@ -134,16 +133,7 @@ function fetchPlugin (plugin_src, plugins_dir, options) {
projectRoot = options.projectRoot;
}
- if (process.platform === 'win32' && parsedSpec.version) {
- var windowsShellSpecialCharacters = ['&', '\\', '<', '>', '^', '|'];
- specContainsSpecialCharacters = windowsShellSpecialCharacters.some(function (character) {
- return parsedSpec.version.indexOf(character);
- });
- }
-
- var fetchPluginSrc = specContainsSpecialCharacters ?
- parsedSpec.package + '@"' + parsedSpec.version + '"' : plugin_src;
- P = fetch(fetchPluginSrc, projectRoot, options);
+ P = fetch(plugin_src, projectRoot, options);
skipCopyingPlugin = false;
}
return P
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-lib] 02/02: TEMP revert to default jasmine reporter
Posted by ra...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch cross-spawn-test
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git
commit 460d3ac39b6f2555f5860f2413ff8063a6445b6d
Author: Raphael von der Grün <ra...@gmail.com>
AuthorDate: Sun Sep 16 17:38:37 2018 +0200
TEMP revert to default jasmine reporter
---
spec/helper.js | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/spec/helper.js b/spec/helper.js
index f1a1782..351e6e4 100644
--- a/spec/helper.js
+++ b/spec/helper.js
@@ -17,17 +17,3 @@
under the License.
*/
jasmine.DEFAULT_TIMEOUT_INTERVAL = 10000;
-
-const SpecReporter = require('jasmine-spec-reporter').SpecReporter;
-
-jasmine.getEnv().clearReporters();
-jasmine.getEnv().addReporter(new SpecReporter({
- spec: {
- displayPending: true,
- displayDuration: true
- },
- summary: {
- displayDuration: true,
- displayStacktrace: true
- }
-}));
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org