[GitHub] [tvm] driazati commented on a diff in pull request #13400: [OpenCL][CI] Enable OpenCL cpp tests in CI

[GitBox <gi...@apache.org>]

driazati commented on code in PR #13400:
URL: https://github.com/apache/tvm/pull/13400#discussion_r1044684769


##########
ci/jenkins/templates/gpu_jenkinsfile.groovy.j2:
##########
@@ -74,6 +74,14 @@
     label: 'Run Java unit tests',
   )
   {% endif %}
+  sh (
+    script: "${docker_run} ${ci_gpu} python3 ./tests/scripts/task_build.py --sccache-bucket tvm-sccache-prod --cmake-target opencl-cpptest --build-dir build",
+    label: 'Make OpenCL cpp unit tests',
+  )
+  sh (
+    script: "${docker_run} ${ci_gpu} ./tests/scripts/task_opencl_cpp_unittest.sh",
+    label: 'Run OpenCL cpp unit tests',
+  )

Review Comment:
   Can you move this next to the `cpp_unittests` above? Right now this job is run 3 times afaik and pytest knows that each job should only run 1/3 of the tests, but this runs all the OpenCL tests 3 times



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org