[jira] [Commented] (HIVE-16855) org.apache.hadoop.hive.ql.exec.mr.HashTableLoader Improvements

["Sahil Takiar (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-16855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16391766#comment-16391766 ] 

Sahil Takiar commented on HIVE-16855:
-------------------------------------

I agree the call to {{Arrays#fill}} is weird, but I don't see a strong reason to remove it; and removing it could have unexpected consequences. Besides that, the rest of the patch LGTM.

> org.apache.hadoop.hive.ql.exec.mr.HashTableLoader Improvements
> --------------------------------------------------------------
>
>                 Key: HIVE-16855
>                 URL: https://issues.apache.org/jira/browse/HIVE-16855
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 2.1.1, 3.0.0
>            Reporter: BELUGA BEHR
>            Assignee: BELUGA BEHR
>            Priority: Minor
>         Attachments: HIVE-16855.1.patch, HIVE-16855.2.patch
>
>
> # Improve (Simplify) Logging
> # Remove custom buffer size for {{BufferedInputStream}} and instead rely on JVM default which is often larger these days (8192)
> # Simplify looping logic



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)