[jira] [Work logged] (GOBBLIN-2146) GaaS SLA flow cancellation is not emitting a flow event which blocks incoming jobs

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-2146?focusedWorklogId=933223&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-933223 ]

ASF GitHub Bot logged work on GOBBLIN-2146:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Sep/24 17:30
            Start Date: 04/Sep/24 17:30
    Worklog Time Spent: 10m 
      Work Description: phet commented on code in PR #4043:
URL: https://github.com/apache/gobblin/pull/4043#discussion_r1744175864


##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/proc/EnforceFlowFinishDeadlineDagProc.java:
##########
@@ -60,7 +60,9 @@ protected void enforceDeadline(DagManagementStateStore dagManagementStateStore,
         DagProcUtils.cancelDagNode(dagNodeToCancel, dagManagementStateStore);
       }
 
-      dag.setFlowEvent(TimingEvent.FlowTimings.FLOW_RUN_DEADLINE_EXCEEDED);
+      DagProcUtils.setAndEmitFlowEvent(eventSubmitter, dag, TimingEvent.FlowTimings.FLOW_CANCELLED);
+
+      log.warn("Killing dag {} due to exceeding SLA of {} ms", getDagId(), flowFinishDeadline);

Review Comment:
   I like this logging, but maybe let's fold it into:
   ```
   log.info("Found {} DagNodes to cancel (DagId {}).", dagNodesToCancel.size(), getDagId());
   ```
   that happens before the attempts to cancel (in case any fail).  `info` level is probably sufficient, with `warn` too severe
   
   (also: SLA => deadline)
   





Issue Time Tracking
-------------------

    Worklog Id:     (was: 933223)
    Time Spent: 50m  (was: 40m)

> GaaS SLA flow cancellation is not emitting a flow event which blocks incoming jobs
> ----------------------------------------------------------------------------------
>
>                 Key: GOBBLIN-2146
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2146
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: William Lo
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> GaaS is not emitting flow level events when SLA killing jobs. This needs to be fixed otherwise the flow status reporting becomes incorrect.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)